Can some1 review my code?

Z

zaheer.agadi

hi

I am from java background, I have written some code that actually
works :)
Need to some one to look at it and tell me if there are better ways of
doing same things

Will some one help?

Thanks
 
J

Jeroen Ruigrok van der Werven

-On [20090419 08:20] said:
Need to some one to look at it and tell me if there are better ways of
doing same things

Just post the snippets of code you want review of.
 
S

Steven D'Aprano

hi

I am from java background, I have written some code that actually works
:)
Need to some one to look at it and tell me if there are better ways of
doing same things

Will some one help?

Are you offering to pay or are you after free advice?

How large is your code? Ten lines, ten thousand lines, ten million lines?

What does it do?


How about if you start with a small, self-contained function (say, 20 to
50 lines) that can be understood in isolation from the rest of your code,
and we'll comment on that.
 
Z

zaheer.agadi

Are you offering to pay or are you after free advice?

How large is your code? Ten lines, ten thousand lines, ten million lines?

What does it do?

How about if you start with a small, self-contained function (say, 20 to
50 lines) that can be understood in isolation from the rest of your code,
and we'll comment on that.

Thanks guys,
I am asking free advice,The program is not very complex it is around
500 lines with most the code being reused, I am bit hesitant to post
the code publicly, is it ok if I send part of code say a function. Or
does it makes more sense if I send the complete code to you guys
personally?
 
B

bearophileHUGS

zaheer.ag...:
I am asking free advice,The program is not very complex it is around
500 lines with most the code being reused,

500 lines is not a small Python program :)
If you don't want to show it, then you can write another program, a
smaller one, for the purpose of letting people review it.

Bye,
bearophile
 
L

liangguanhui

hi

I am from java background, I have written some code that actually
works :)
Need to some one to look at it and tell me if there are better ways of
doing same things

Will some one help?

Thanks

Post first, then someone will review, I think.
 
Z

zaheer.agadi

When done all this you might feel it is not necessary to review the code
any more, which is then is a good moment to actually request a review :)
I'll be happy to have a look at it though you might consider posting it
here, more chance of useful feedback ;-)

Great, Thanks a lot I will make sure that I complete what ever you
have listed here and then
request for a review. Well I understand that refusing to post the code
here in the mailing list might
annoy people and posting code here will only help it making it more
robust and clean. I am just being cautious that I don't break any of
the laws at my workplace.
 
D

David Lees

Great, Thanks a lot I will make sure that I complete what ever you
have listed here and then
request for a review. Well I understand that refusing to post the code
here in the mailing list might
annoy people and posting code here will only help it making it more
robust and clean. I am just being cautious that I don't break any of
the laws at my workplace.
I would second what another poster recommended. Post snippets. My
experience over the last 8 years is that a short post on a single issue
elicits very helpful responses. Also these days there many books on
Python; find one that suits your learning style.


David Lees
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Members online

Forum statistics

Threads
473,744
Messages
2,569,479
Members
44,900
Latest member
Nell636132

Latest Threads

Top