Class variables and how to set them up only once.

[Kyle Schmitt]

I'm trying to share a File object with everything that inherits from
Superclass, for logging.

I'm trying to come up with a nice clean way of handling this, and this isn't it:
Right now it's doing a begin/rescue/end to see if the @@logger.nil?
(which throws an error if it doesn't exist), and setup @@logger in the
rescue.

The other thought I had was to take the setupLogger out of initialize,
have a single dummy instance of SuperPage, and call setupLogger from
that class once. That seems even worse.

I'm sure other people can think of more elegant ways of handling this,
and I'd sure like to hear their suggestions

I tried putzing around with class_variables, but I couldn't seem to
get at those from within a class.


--Kyle

class SuperPage
def initialize()
#lots of stuff
setupLogger()#setsup an @@logger member that the log methods use
ObjectSpace.define_finalizer(self, SuperPage.create_finalizer(@@logger))
end

def logError(message)
logError,message)
throw :assertion_error
end

def log(type,message)
@@logger.puts("#{...ugly long string that includes the message...}")
end

def setupLogger(path="c:\\#{DateTime.now.to_s.gsub(':','-')}.xml")
begin
@@logger.nil?
rescue
puts "I'm setting up the logger, you should only see me once"
@@logger=File.new("c:\\#{DateTime.now.to_s.gsub(':','-')}.xml","w")
@@logger.puts "<log>"
@loggerSetup=true
end
end
end

 

[Kyle Schmitt]

And after I said I couldn't find a way of getting at class_variables
from inside the class, the obvious occurred to me, whether or not it's
the 'right' way.
self.class.class_variables

 

[Kyle Schmitt]

Right, so the way I wrote previously, or this way:

def setupLogger(path="c:\\#{DateTime.now.to_s.gsub(':','-')}.xml")
unless self.class.class_variables.include?"@@logger"
puts "I'm setting up the logger, you should only see me once"
@@logger=File.new("c:\\#{DateTime.now.to_s.gsub(':','-')}.xml","w")
@@logger.puts "<log>"
@loggerSetup=true
end
end

 

[Robert Klemme]

I'm trying to share a File object with everything that inherits from
Superclass, for logging.

The other thought I had was to take the setupLogger out of initialize,
have a single dummy instance of SuperPage, and call setupLogger from
that class once. That seems even worse.

I'm sure other people can think of more elegant ways of handling this,
and I'd sure like to hear their suggestions

There is at least one logging package for Ruby (Log4R). I'd use that
one instead of creating my own.

Kind regards

robert

 

[dblack]

Hi --

Right, so the way I wrote previously, or this way:

def setupLogger(path="c:\\#{DateTime.now.to_s.gsub(':','-')}.xml")
unless self.class.class_variables.include?"@@logger"
puts "I'm setting up the logger, you should only see me once"
@@logger=File.new("c:\\#{DateTime.now.to_s.gsub(':','-')}.xml","w")
@@logger.puts "<log>"
@loggerSetup=true
end
end

What about:

@@logger ||= File.new ....


David

--
* Books:
RAILS ROUTING (new! http://www.awprofessional.com/title/0321509242)
RUBY FOR RAILS (http://www.manning.com/black)
* Ruby/Rails training
& consulting: Ruby Power and Light, LLC (http://www.rubypal.com)

 

[Kyle Schmitt]

dblack,
I've never tried to use ||= before... but damn if that
doesn't work well! I was expecting it to die like my @@whatever=:this
unless @@whatever had when I tried that. Neat!


Robert,
I've found the docs for log4r to be slightly better than
those for well.. umm. nothing. There about the worst docs I've found
for a widely used package I've used log4r in other projects
several months ago, but didn't feel like going through the pain of
setting it up and re-learning it. While it's a good lib, the docs are
horrible.

Thanks,
Kyle