Code Review request for the trash-cli project

Discussion in 'Python' started by Andrea Francia, Jan 6, 2009.

  1. The trash-cli project is a opensource implementation of the
    FreeDesktop.org Trash Specification that provides a command line
    interface to manage the trashcan.

    It's provide the following commands:
    * trash-put trashes files and directories.
    * trash-empty empty the trashcan(s).
    * trash-list list trashed file.
    * trash-restore restore a trashed file.

    It is written in python and its sources are available at

    http://code.google.com/p/trash-cli/source/browse/#svn/trunk

    I'm the main developer and I'm not so good in Python as I would be.

    Would you review my software and point out the problems you see?

    The review comments can be written using the code-review facilities of
    google code. You need only to double click the line of code where you
    want add a comment.

    Patches are also welcome.

    Thank you.
    Andrea Francia, Jan 6, 2009
    #1
    1. Advertising

  2. Dotan Cohen wrote:
    > 2009/1/6 Andrea Francia
    > <-here.gmx.it>:
    >> The trash-cli project is a opensource implementation of the FreeDesktop.org

    >
    > I don't know about the code, but would there be a reason _not_ to
    > alias rm, rmdir to this program?


    Actually the trash-put command accept all the options of GNU rm in order
    allows user doing alias rm='trash-put', but it does not accept yet some
    GNU rmdir options (--ignore-fail-on-non-empty, -p, --parents).

    A enhancement issue about accepting rmdir options was added to the tracker.

    > I see that it is GPL, so this would
    > be a great addition to any Linux distro.


    It's available in some distro but many distro uses a very old version,
    to gain all the advantages of the latest development version you can use:

    easy_install trash-cli

    The easy_install command is provided by the python-setuptools package.
    Andrea Francia, Jan 6, 2009
    #2
    1. Advertising

  3. On Tue, 06 Jan 2009 17:30:19 +0200, Dotan Cohen wrote:

    > I don't know about the code, but would there be a reason _not_ to alias
    > rm, rmdir to this program? I see that it is GPL, so this would be a
    > great addition to any Linux distro.


    I sure as hell don't want rm to move files to the trash. If I rm
    something, I want it *gone*.

    I do want a *different* command for moving files to the trash. But
    absolutely not rm.

    Of course, if anyone wants to alias rm in their own shell, they're
    welcome to. That's what the alias command is for.



    --
    Steven
    Steven D'Aprano, Jan 6, 2009
    #3
    1. Advertising

Want to reply to this thread or ask your own question?

It takes just 2 minutes to sign up (and it's free!). Just click the sign up button to choose a username and then you can ask your own questions on the forum.
Similar Threads
  1. Tommy

    asp.net controls are trash

    Tommy, Nov 11, 2003, in forum: ASP .Net
    Replies:
    11
    Views:
    594
    S. Justin Gengo
    Nov 12, 2003
  2. www
    Replies:
    51
    Views:
    1,440
  3. 0
    Replies:
    4
    Views:
    831
  4. 0
    Replies:
    5
    Views:
    2,023
    laurenelizabeth
    Sep 3, 2010
  5. Ben Schaffhausen
    Replies:
    5
    Views:
    145
    John Labovitz
    Sep 21, 2006
Loading...

Share This Page