Code review requested

Discussion in 'Java' started by Ian Pilcher, Dec 15, 2003.

  1. Ian Pilcher

    Ian Pilcher Guest

    I have created a class which extends BufferedInputStream and allows me
    to turn off the buffering functionality. I'm pretty new to Java
    programming, and I'm a little uncomfortable mucking about with the
    internals of one of the API classes -- even though I've done my best to
    rely only on the documented behavior of BufferedInputStream.

    I'm hoping someone with a little more experience will take a couple of
    minutes to look over the code at

    http://home.comcast.net/~i.pilcher/TempBufferedInputStream.java

    and let me know if I've made any really glaring errors.

    If anyone wants to compile the code, you'll also need

    http://home.comcast.net/~i.pilcher/StreamNotBufferingException.java

    I've taken the "brute force" approach of making every public method
    synchronized; I'd be interesting in hearing if there are any places
    where this may not be necessary.

    Finally, if anyone has any suggestions for better (shorter) class names,
    I'd love to hear them.

    Thanks!
    --
    ========================================================================
    Ian Pilcher
    ========================================================================
     
    Ian Pilcher, Dec 15, 2003
    #1
    1. Advertising

Want to reply to this thread or ask your own question?

It takes just 2 minutes to sign up (and it's free!). Just click the sign up button to choose a username and then you can ask your own questions on the forum.
Similar Threads
  1. Ed

    Code review requested

    Ed, Jul 19, 2004, in forum: Java
    Replies:
    1
    Views:
    360
    Filip Larsen
    Jul 19, 2004
  2. Mike Wahler
    Replies:
    1
    Views:
    394
    E. Robert Tisdale
    Oct 18, 2004
  3. Vyacheslav Kononenko

    Re: Code review requested, Accelerated C++

    Vyacheslav Kononenko, Oct 18, 2004, in forum: C++
    Replies:
    0
    Views:
    493
    Vyacheslav Kononenko
    Oct 18, 2004
  4. www
    Replies:
    51
    Views:
    1,485
  5. luserXtrog

    A little light code review requested

    luserXtrog, Aug 18, 2010, in forum: C Programming
    Replies:
    2
    Views:
    340
    luserXtrog
    Aug 18, 2010
Loading...

Share This Page