Code review requested

I

Ian Pilcher

I have created a class which extends BufferedInputStream and allows me
to turn off the buffering functionality. I'm pretty new to Java
programming, and I'm a little uncomfortable mucking about with the
internals of one of the API classes -- even though I've done my best to
rely only on the documented behavior of BufferedInputStream.

I'm hoping someone with a little more experience will take a couple of
minutes to look over the code at

http://home.comcast.net/~i.pilcher/TempBufferedInputStream.java

and let me know if I've made any really glaring errors.

If anyone wants to compile the code, you'll also need

http://home.comcast.net/~i.pilcher/StreamNotBufferingException.java

I've taken the "brute force" approach of making every public method
synchronized; I'd be interesting in hearing if there are any places
where this may not be necessary.

Finally, if anyone has any suggestions for better (shorter) class names,
I'd love to hear them.

Thanks!
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Members online

Forum statistics

Threads
473,755
Messages
2,569,536
Members
45,007
Latest member
obedient dusk

Latest Threads

Top