Code review

Discussion in 'C++' started by Ebenezer, Jan 30, 2011.

  1. Ebenezer

    Ebenezer Guest

    I'd like to request comments on the code in the archive on
    this page -- http://webEbenezer.net/build_integration.html .
    As you may know, I'm working on an on line code generator
    that writes C++ marshalling code based on user input. I use
    a three-tier architecture as follows:


    C++ Middleware Writer (CMW) -- this is a server ... closed source


    C++ Middleware Writer Ambassador (CMWA) -- this is a server ... open
    source


    "direct" program -- this program runs once and exits ... open source


    The two open source tiers are in the archive mentioned above along
    with supporting files. One of the files in the archive,
    msg_shepherd.hh, is output from the CMW. That file is based on
    another file in the archive called direct.mdl as well as some include
    files.


    One thing that I expect will be brought up is that the software
    mixes naming conventions. I haven't picked one and been
    consistent with it as is sometimes advised. I agree with that advice
    for the most part, but have been lazy about following it so far.

    There's a mediateResponse function in the CMWA that may
    result in comments. Some knowledge of the CMW is needed ---
    if the returned transaction number is zero, the value of the request
    result (reqResult) will be false. I can only think of things like
    sun storms that would cause this to be violated. But it wouldn't
    be difficult to add code that checks if returnedTransactionNbr is
    zero and reqResult is true and throws an exception.


    In the "direct" program the function that connects to the
    ambassador uses 127.0.0.1. That needs to be worked on.

    The software in the archive has been tested on Linux and Windows.
    I'd appreciate advice on improving the existing code as well as
    suggestions of new functionality. There are about 3800 lines of
    code in the archive. I realize people are busy and most can't
    review all of it. If you would review a function or a class that
    would be helpful. Thanks in advance.


    Brian Wood
    Ebenezer Enterprises
    http://webEbenezer.net
    (651) 251-9384
    Ebenezer, Jan 30, 2011
    #1
    1. Advertising

  2. Ebenezer

    Ebenezer Guest

    On Jan 30, 10:34 am, Ebenezer <> wrote:
    > I'd like to request comments on the code in the archive on
    > this page --http://webEbenezer.net/build_integration.html.
    > As you may know, I'm working on an on line code generator
    > that writes C++ marshalling code based on user input.   I use
    > a three-tier architecture as follows:
    >
    > C++ Middleware Writer (CMW)  --  this is a server ... closed source
    >
    > C++ Middleware Writer Ambassador (CMWA) -- this is a server ... open
    > source
    >
    > "direct" program  -- this program runs once and exits ... open source
    >
    > The two open source tiers are in the archive mentioned above along
    > with supporting files.  One of the files in the archive,
    > msg_shepherd.hh, is output from the CMW.  That file is based on
    > another file in the archive called direct.mdl as well as some include
    > files.
    >
    >


    I was reviewing the code some recently and have a question about
    changing my API. In msg_shepherd.hh, there's a function with this
    signature:

    void
    Send(SendCompressedBuffer& buf, const std::vector<cmw_account_info>&
    abt1);

    I'm considering making the buffer parameter the last one rather
    than the first one. My current approach is similar to the
    interface of write. Thinking about how fwrite's interface is
    different from write's interface made me wonder if I should
    change the interface now before it becomes more difficult to
    do so in the future. The fwrite interface seems to have a
    "who, what, when, where, why, how" approach. The "how" being
    via the file handle or buffer in my case. What do you suggest?
    Ebenezer, Jan 30, 2011
    #2
    1. Advertising

Want to reply to this thread or ask your own question?

It takes just 2 minutes to sign up (and it's free!). Just click the sign up button to choose a username and then you can ask your own questions on the forum.
Similar Threads
  1. Volodymyr Sadovyy

    Code write \ code review productivity

    Volodymyr Sadovyy, Apr 23, 2004, in forum: Java
    Replies:
    8
    Views:
    737
    Roedy Green
    Apr 25, 2004
  2. Otto Wyss
    Replies:
    5
    Views:
    394
    Robert Vazan
    Sep 7, 2003
  3. andrew blah
    Replies:
    6
    Views:
    346
    andrew blah
    Oct 17, 2004
  4. Josiah Carlson
    Replies:
    1
    Views:
    339
    Andrew Clover
    Oct 13, 2004
  5. www
    Replies:
    51
    Views:
    1,448
Loading...

Share This Page