Comment on accessor coding

[-]

Please comment on the following and provide a professional alternative
if possible:

public Object getObject(Object object) {
Object obj = null;

// if (object != null) { <---- Qn 1: Should I check for null?
for (Object o : objects) {
if (object.equals(o) { <---- Qn 2: Or if (o.equals(object)) ?
obj = o; If i do this, then I don't
break; need to check for null.
}
}
//}

return obj;
}

 

[Fred L. Kleinschmidt]

Please comment on the following and provide a professional alternative
if possible:

public Object getObject(Object object) {
Object obj = null;

// if (object != null) { <---- Qn 1: Should I check for null?
for (Object o : objects) {
if (object.equals(o) { <---- Qn 2: Or if (o.equals(object)) ?
obj = o; If i do this, then I don't
break; need to check for null.
}
}
//}

return obj;
}

This method seems to be pretty useless. Why do you need to get an object
you already have?

Unless you are checking to see whether the input object is in your
current array of objects. In that case, getObject is a poor choice for
the nameof this method.

 

[Lucy]

<snip>

I check for null every time I use an object.