Count total no. of characters,words & sentences in a text file

[Umesh]

Please try to do it while I try myself!

 

[Richard Heathfield]

Umesh said:

Please try to do it while I try myself!

Look what happened the last time you cross-posted to clc and clc++.

Pick a language - any language - but pick ONE language, and post to the
newsgroup appropriate to that language.

The problem to which you refer is one of the easier K&R examples, and
should cause you no difficulty.

 

[osmium]

Please try to do it while I try myself!

Men don't talk much about doing "it".

Doing the counts you mention would probably be easier if you wrote three
separate functions, that way you only have one train of thought at a time.

 

[Default User]

Please try to do it while I try myself!

Quit cross-posting between groups. I don't think you will get much help
if you continue this anti-social behavior.

Figure out which language you are working in, then post to that group.



Brian

 

[Colander]

Please try to do it while I try myself!

done
system("wc");

 

[Lew Pitcher]

Please try to do it while I try myself!

Already done, and (IIRC) published.

We'll be happy to take a look at your solution, any time you wish to
post it

 

[Umesh]

#include<stdio.h>
int main(void)
{
long int ch,c,num=0,num1=0,num2=0,num3=0;
FILE *f;
f=fopen("c:/1.txt","r");
while((ch=getc(f))!=EOF && (ch=getc(f))!=EOF)
{
if(ch==' ') ++num;
if(ch=='.') ++num1;
if(ch<=256) ++num2;
if(ch=='.' && c!=' ') ++num3; /* '.' followed by '.' denotes end of a
sentence.*/
}
printf("\nNo. of spaces = %ld",num);
printf("\nNo. of full stops = %ld",num1);
printf("\nNo. of characters = %ld",num2);
printf("\nNo. of characters without spaces = %ld",num2-num);
printf("\nNo. of sentences = %ld",num3);
return 0;
}

 

[osmium]

:

Just a couple of random observations.

#include<stdio.h>
int main(void)
{
long int ch,c,num=0,num1=0,num2=0,num3=0;

Your choice of names is not very helpful.

FILE *f;
f=fopen("c:/1.txt","r");
while((ch=getc(f))!=EOF && (ch=getc(f))!=EOF)
{
if(ch==' ') ++num;
if(ch=='.') ++num1;
if(ch<=256) ++num2;
if(ch=='.' && c!=' ') ++num3; /* '.' followed by '.' denotes end of a

I doubt you wanted '=' in there.
In the US, a sentence is usually indicated by ". " , two spaces.

sentence.*/
}
printf("\nNo. of spaces = %ld",num);
printf("\nNo. of full stops = %ld",num1);
printf("\nNo. of characters = %ld",num2);
printf("\nNo. of characters without spaces = %ld",num2-num);
printf("\nNo. of sentences = %ld",num3);
return 0;
}

This looks like a draft. I would not think you were happy with it because
of the = above. When you get happy with it, try to improve it. For
example, handle hyphenated words, at least the simple cases. I don't think
they can all be resolved without a dictionary. Following Google rules for
words seems fine to me. AFAIK, they have no rules for sentences.

 

[Ian Collins]

#include<stdio.h>
int main(void)
{
long int ch,c,num=0,num1=0,num2=0,num3=0;
FILE *f;
f=fopen("c:/1.txt","r");
while((ch=getc(f))!=EOF && (ch=getc(f))!=EOF)

You never learn, do you?

 

[Lew Pitcher]

Please try to do it while I try myself!

It's been done.

When you have something, post it here, and we'll take a look at it.

 

[Salt_Peter]

Please try to do it while I try myself!

I tried and it worked. Its fast too.
Counts whitespaces and detects a sentence not ending in '.' as well
(ie: '?' or '!').
perhaps what follows might help:
http://www.parashift.com/c++-faq-lite/how-to-post.html#faq-5.2

 

[Bill Pursell]

Please try to do it while I try myself!

This works for one case.

#include <stdio.h>

#define FORMAT "Characters: %s\tWords: %s\tSentences: %s\n"
#define ZERO "0"
#define GT "at least one"
#define UNK "unknown"

int main( void )
{
int c;

if( EOF == getchar())
printf( FORMAT, 0, 0, 0 );
else
printf( FORMAT, GT, UNK, UNK );
}

 

[Default User]

[clc++ remove]

#include<stdio.h>
int main(void)
{
long int ch,c,num=0,num1=0,num2=0,num3=0;
FILE *f;
f=fopen("c:/1.txt","r");

How many times have you been told to check for failure when using
fopen()? Why should we bother telling you anything if you won't listen?




Brian

 

[Umesh]

Please try to do it while I try myself!

#include<stdio.h>
int main(void)
{
long int ch,c,num=0,num1=0,num2=0,num3=0;
FILE *f;
f=fopen("c:/1.txt","r");
while((ch=getc(f))!=EOF && (ch=getc(f))!=EOF)
{
if(ch==' ') ++num;
if(ch=='.') ++num1;
if(ch<=256) ++num2;
if(ch=='.' && c!=' ') ++num3; // '.' followed by '.' denotes end of a
sentence.
}
printf("\nNo. of spaces = %ld",num);
printf("\nNo. of full stops = %ld",num1);
printf("\nNo. of characters = %ld",num2);
printf("\nNo. of characters without spaces = %ld",num2-num);
printf("\nNo. of sentences = %ld",num3);
return 0;
}

 

[CBFalconer]

Please try to do it while I try myself!

Try to do what? What are you going to try yourself for?

F'ups set.

 

[Default User]

[quit cross-posting]

Umesh wrote:

while((ch=getc(f))!=EOF && (ch=getc(f))!=EOF)

What the hell is this supposed to do?




Brian

 

[Umesh]

//Sorry my teachers. I've included file opening check in this program.

#include<stdio.h>
int main(void)
{
long int ch,c,num=0,num1=0,num2=0,num3=0;
FILE *f;
f=fopen("c:/1.txt","r");
if (f!=NULL)
{
while((ch=getc(f))!=EOF && (ch=getc(f))!=EOF)
{
if(ch==' ') ++num;
if(ch=='.') ++num1;
if(ch<=256) ++num2;
if(ch=='.' && c!=' ') ++num3; // '.' followed by '.' denotes end of a
sentence.
}
printf("\nNo. of spaces = %ld",num);
printf("\nNo. of full stops = %ld",num1);
printf("\nNo. of characters = %ld",num2);
printf("\nNo. of characters without spaces = %ld",num2-num);
printf("\nNo. of sentences = %ld",num3);
}
else printf("Error in opening file c:/1.txt ");
return 0;
}

 

[Keith Thompson]

#include<stdio.h>
int main(void)
{
long int ch,c,num=0,num1=0,num2=0,num3=0;
FILE *f;
f=fopen("c:/1.txt","r");
while((ch=getc(f))!=EOF && (ch=getc(f))!=EOF)
{
if(ch==' ') ++num;
if(ch=='.') ++num1;
if(ch<=256) ++num2;
if(ch=='.' && c!=' ') ++num3; /* '.' followed by '.' denotes end of a
sentence.*/
}
printf("\nNo. of spaces = %ld",num);
printf("\nNo. of full stops = %ld",num1);
printf("\nNo. of characters = %ld",num2);
printf("\nNo. of characters without spaces = %ld",num2-num);
printf("\nNo. of sentences = %ld",num3);
return 0;
}

This program has numerous problems, which I'll be happy to discuss
with you if you pick *one* newsgroup to post to (if that newsgroup
happens to be comp.lang.c; I don't regularly read comp.lang.c++).
C and C++ are two different languages, and cross-posting between
comp.lang.c and comp.lang.c++ is almost never a good idea.

But the first thing you should do is to run the program and take a
look at its output (hint: the results it reports are incorrect).

 

[Ian Collins]

//Sorry my teachers. I've included file opening check in this program.

#include<stdio.h>
int main(void)
{
long int ch,c,num=0,num1=0,num2=0,num3=0;

Use meaningful names and declare them in the scope where they are used.

FILE *f;
f=fopen("c:/1.txt","r");

Whitespace is free, use it. This will only work on a system where
"c:/1.txt" is a valid filename and where "c:/1.txt" exists...

if (f!=NULL)
{
while((ch=getc(f))!=EOF && (ch=getc(f))!=EOF)

Why are you doing this?

{
if(ch==' ') ++num;
if(ch=='.') ++num1;
if(ch<=256) ++num2;
if(ch=='.' && c!=' ') ++num3; // '.' followed by '.' denotes end of a
sentence.

If you are going to add comments, make sure they make sense and agree
with the code.

 

[John Bode]

#include<stdio.h>
int main(void)
{
long int ch,c,num=0,num1=0,num2=0,num3=0;

Use meaningful names, for both your sanity and ours; if num is meant
to count characters, indicate that with a name like numChars; if num1
is meant to count stops, name it numStops. Also, what is the purpose
of c, other than to introduce a bug later on?

FILE *f;
f=fopen("c:/1.txt","r");
while((ch=getc(f))!=EOF && (ch=getc(f))!=EOF)

Why are you reading two characters at a time? You're only going to
wind up checking every other character in the text file. I'm
reasonably sure that's not what you want to do.

{
if(ch==' ') ++num;
if(ch=='.') ++num1;
if(ch<=256) ++num2;
if(ch=='.' && c!=' ') ++num3; // '.' followed by '.' denotes end of a
sentence.}

What about sentences that end with '?' or '!'? What about
abbreviations or titles like Mr. or Dr.? And when did you assign
something to c?