file handling - a simple explanation?

[Geoff Cox]

Hello,

I am getting the following error message for the last 3 files being
processed only, and must be doing something wrong - not sure what
though. The code works.

print() on closed filehandle OUT2 at hp3.pl line 33, <IN> line 12.

The code is

open (IN, $name);
open OUT, (">>hp-$name");
open OUT2, (">>html/hp-index.htm");

while (defined(my $line = <IN>)) {

if ($line =~ /<title>(.*?)- (.*?)<\/title>/) {
print OUT2 ('<a href="hp-$htmlname.htm">$1 $2</a> <br>\n');


Thanks for any ideas.

Geoff

 

[John Bokma]

Hello,

I am getting the following error message for the last 3 files being
processed only, and must be doing something wrong - not sure what
though. The code works.

print() on closed filehandle OUT2 at hp3.pl line 33, <IN> line 12.

The code is
bad

open (IN, $name);

or die "Can't open '$name': $!";

open OUT, (">>hp-$name");

or die ...

open OUT2, (">>html/hp-index.htm");

or die ...

Also, put use strict; and use warnings; on top of your script if you
haven't done so.

 

[Gunnar Hjalmarsson]

Hello,

I am getting the following error message for the last 3 files being
processed only, and must be doing something wrong - not sure what
though. The code works.

print() on closed filehandle OUT2 at hp3.pl line 33, <IN> line 12.

The code is

open (IN, $name);
open OUT, (">>hp-$name");
open OUT2, (">>html/hp-index.htm");

Yes, you are doing something wrong. You are not checking for success
when opening files.

open IN, $name or die "Couldn't open $name: $!";

 

[Geoff Cox]

bad

John,

Thanks - I added the or die etc and then found that I had one
directory which did not have the sub directory expected by the code!

I am now converted to having the or die etc,.

Cheers

Geoff

 

[Geoff Cox]

Yes, you are doing something wrong. You are not checking for success
when opening files.

open IN, $name or die "Couldn't open $name: $!";

Thanks Gunnar - I corrected the code and then realised it expected a
sub directory which was not there. I am now convinced not to be lazy
re the or die!

Cheers

Geoff