Frozen OpenStruct allows modification

[bhz]

Why does OpenStruct allow modification after it has been frozen? Output is
20 in both ruby 1.8.6 and 1.9:

require 'ostruct'

a = OpenStruct.new()
a.foo = 10
a.freeze()
a.foo = 20
puts a.foo

 

[Stefan Lang]

Why does OpenStruct allow modification after it has been frozen? Output is
20 in both ruby 1.8.6 and 1.9:

require 'ostruct'

a = OpenStruct.new()
a.foo = 10
a.freeze()
a.foo = 20
puts a.foo

Because the OpenStruct instance is never modified here,
only the internal hash it uses to store attribute values.
The internal hash is not frozen, only the OpenStruct instance
itself.

Stefan

 

[Robert Klemme]

Because the OpenStruct instance is never modified here,
only the internal hash it uses to store attribute values.
The internal hash is not frozen, only the OpenStruct instance
itself.

That could still be considered a bug and IMHO it is.

Kind regards

robert

 

[Robert Dober]

Because the OpenStruct instance is never modified here,
only the internal hash it uses to store attribute values.
The internal hash is not frozen, only the OpenStruct instance

Sounds like a bug to me.
Robert

 

[bhz]

That could still be considered a bug and IMHO it is.

Kind regards

robert

Agreed.

 

[Robert Dober]

I have submitted a patch to ruby-core.

Turned out that this was certainly an error only *already* created
write accessors were ignoring the frozen? state of the object, thus

x =OpenStruct::new.freeze
x.a = 42

would have thrown the expected TypeError.

Cheers
Robert



--
There are some people who begin the Zoo at the beginning, called
WAYIN, and walk as quickly as they can past every cage until they get
to the one called WAYOUT, but the nicest people go straight to the
animal they love the most, and stay there. ~ A.A. Milne (from
Winnie-the-Pooh)

 

[Robert Klemme]

I have submitted a patch to ruby-core.

Well done!

Turned out that this was certainly an error only *already* created
write accessors were ignoring the frozen? state of the object, thus

x =OpenStruct::new.freeze
x.a = 42

would have thrown the expected TypeError.

Thanks for the update and the insights!

Kind regards

robert

 

[bhz]

I have submitted a patch to ruby-core.

Turned out that this was certainly an error only *already* created
write accessors were ignoring the frozen? state of the object, thus

x =OpenStruct::new.freeze
x.a = 42

would have thrown the expected TypeError.

Cheers
Robert

Thanks for input. So we can expect it to be fixed in the new release?

 

[Robert Dober]

Thanks for input. So we can expect it to be fixed in the new release?

I really do not know, depends if my patch or Joel's will be accepted,
but I see no reason why not .
R.



--
There are some people who begin the Zoo at the beginning, called
WAYIN, and walk as quickly as they can past every cage until they get
to the one called WAYOUT, but the nicest people go straight to the
animal they love the most, and stay there. ~ A.A. Milne (from
Winnie-the-Pooh)

 

[Robert Dober]

They fixed it
R