Got some syntax error I can't spot. Can you (I hope)?

[RichardOnRails]

Hi all,

I pulled my problem code from my app into a test on http://www.pastie.org/436616.

Lines 13-19 are the problem code in my app.

Lines preceding them I set up needed definitions and test individual
components of the problematic code.

The final lines display the error lines 13-19 produce. Can you see
what the problem is?

Thanks in Advance,
Richard

 

[Bill Kelly]

I pulled my problem code from my app into a test on http://www.pastie.org/436616.

Lines 13-19 are the problem code in my app.

Lines preceding them I set up needed definitions and test individual
components of the problematic code.

The final lines display the error lines 13-19 produce. Can you see
what the problem is?

Precedence problem with + and % apparently. This works:

puts(("Considering saving the trade-group" +
"\tfor symbol \"%s\", "+
"\tgroup size: %d, " +
"\tand # groups saved thus far: " +
"open(%d), " +
"completed(%d)") %
[savedSymbol, tradeGroup.size, openTrades.size, completedTrades.size])


Regards,

Bill

 

[Martin DeMello]

Hi all,

I pulled my problem code from my app into a test on http://www.pastie.org= /436616.

Lines 13-19 are the problem code in my app.

Lines preceding them I set up needed definitions and test individual
components of the problematic code.

The final lines display the error lines 13-19 produce. =A0Can you see
what the problem is?

It's a precedence thing - % has higher precedence than +. Try this:

# before
puts "Considering saving the trade-group" +
"\tfor symbol \"%s\", "+
"\tgroup size: %d, " +
"\tand # groups saved thus far: " +
"open(%d), " +
"completed(%d)" %
[savedSymbol, tradeGroup.size, openTrades.size, completedTrades.size]

# after

puts ("Considering saving the trade-group" +
"\tfor symbol \"%s\", "+
"\tgroup size: %d, " +
"\tand # groups saved thus far: " +
"open(%d), " +
"completed(%d)") %
[savedSymbol, tradeGroup.size, openTrades.size, completedTrades.size]

martin

 

[RichardOnRails]

Hi all,

I pulled my problem code from my app into a test onhttp://www.pastie.org/436616.

Lines 13-19 are the problem code in my app.

Lines preceding them I set up needed definitions and test individual
components of the problematic code.

The final lines display the error lines 13-19 produce.  Can you see
what the problem is?

Thanks in Advance,
Richard

My brain finally thawed. I a movie decades ago, a Dustin Hoffman
character was told the "plastic" was the key to success. For my
current problem, the key was "parentheses"! I appended the
correction to the Pastie post.\

My apology for wasting your time with my stupidity.

Best wishes,
Richard

 

[RichardOnRails]

From: "RichardOnRails" <[email protected]>

I pulled my problem code from my app into a test onhttp://www.pastie.org/436616.

Lines 13-19 are the problem code in my app.

Lines preceding them I set up needed definitions and test individual
components of the problematic code.

The final lines display the error lines 13-19 produce.  Can you see
what the problem is?

Precedence problem with + and % apparently.  This works:

puts(("Considering saving the trade-group"   +
  "\tfor symbol \"%s\", "+
  "\tgroup size: %d, " +
  "\tand # groups saved thus far: " +
      "open(%d), " +
      "completed(%d)") %
      [savedSymbol, tradeGroup.size, openTrades.size, completedTrades.size])

Regards,

Bill

Hi Bill,

Many thanks for your solution. It looks like you posted your response
about 15 minutes after I posted my question.

I posted my Eureka moment about an hour after I posted my question,
though it seemed to me to have been much sooner than that, so I never
checked to see whether anyone had posted a response.

So I don't know which to be happier about. That my brain began
functioning again, of that this newsgroup is attended by such
wonderful people like you and Martin.

Again, thank you and
Best wishes,

Richard

 

[RichardOnRails]

Hi all,

I pulled my problem code from my app into a test onhttp://www.pastie.org/436616.

Lines 13-19 are the problem code in my app.

Lines preceding them I set up needed definitions and test individual
components of the problematic code.

The final lines display the error lines 13-19 produce.  Can you see
what the problem is?

It's a precedence thing - % has higher precedence than +. Try this:

# before
puts "Considering saving the trade-group"     +
  "\tfor symbol \"%s\", "+
  "\tgroup size: %d, " +
  "\tand # groups saved thus far: " +
      "open(%d), " +
      "completed(%d)" %
      [savedSymbol, tradeGroup.size, openTrades.size, completedTrades.size]

# after

puts ("Considering saving the trade-group"    +
  "\tfor symbol \"%s\", "+
  "\tgroup size: %d, " +
  "\tand # groups saved thus far: " +
      "open(%d), " +
      "completed(%d)") %
      [savedSymbol, tradeGroup.size, openTrades.size, completedTrades.size]

martin

Thanks in Advance,
Richard

Hi Martin,

I posted an equivalent of the following post to Bill Kelly:

Many thanks for your solution. It looks like you posted your response
about 20 minutes after I posted my question.

I posted my Eureka moment about an hour after I posted my question,
though it seemed to me to have been much sooner than that, so I never
checked to see whether anyone had posted a response.

So I don't know which to be happier about. That my brain began
functioning again, of that this newsgroup is attended by such
wonderful people like you and Bill.

Again, thank you and
Best wishes,

Richard

 

[Leo]

I pulled my problem code from my app into a test onhttp://www.pastie.org/436616.

You might want to take a look at ruby's heredoc syntax:

Instead of

a = ("foo" + "(%d)" + " bar") % 123

you could also use:

a = <<TEXT % 123
foo(%d) bar
TEXT

 

[RichardOnRails]

You might want to take a look at ruby's heredoc syntax:

Instead of

    a = ("foo" + "(%d)" + " bar") % 123

you could also use:

    a = <<TEXT % 123
    foo(%d) bar
    TEXT

Hi Leo,

Nice idea! Saves typing (and mistyping!) all those quotes, pluses, \n
and \t. Works great!

Many thanks and
Best wishes,
Richard