int('2.1') does not work while int(float('2.1')) does

V

Vineet Jain

int('2.1') does not work while int(float('2.1')) does. If int can covert a
float object then there is no reason why a float string should not be
converted too.

When I do int('2.1') I get the following error:
Traceback (most recent call last):
File "<stdin>", line 1, in ?
ValueError: invalid literal for int(): 2.0

This does not seem very pythonic

VJ
 
E

Erik Max Francis

Vineet said:
int('2.1') does not work while int(float('2.1')) does. If int can
covert a
float object then there is no reason why a float string should not be
converted too.

When I do int('2.1') I get the following error:

Traceback (most recent call last):
File "<stdin>", line 1, in ?
ValueError: invalid literal for int(): 2.0

This does not seem very pythonic

There's a fundamental difference between an int and a float. If the
string you're trying to convert looks like a float, that means it
doesn't look like an int.

With your first example of '2.1', what should it mean? Should it
truncate, round to negative infinity round to positive infinity, round
to zero, what? Python can't guess for you, so it shouldn't try. Thus
it's an error.
 
J

Joe Mason

There's a fundamental difference between an int and a float. If the
string you're trying to convert looks like a float, that means it
doesn't look like an int.

With your first example of '2.1', what should it mean? Should it
truncate, round to negative infinity round to positive infinity, round
to zero, what? Python can't guess for you, so it shouldn't try. Thus
it's an error.

Why can it make this guess for "int(2.1)", then? It's got a rule for
converting floats to ints - why not use it here?

Joe
 
E

Erik Max Francis

Joe said:
Why can it make this guess for "int(2.1)", then? It's got a rule for
converting floats to ints - why not use it here?

Because int(aFloat) means round toward zero. int(aString) means make an
int out of this string.
 
J

Joe Mason

Because int(aFloat) means round toward zero. int(aString) means make an
int out of this string.

So why can't int(string) mean round toward zero?

Joe
 
D

Duncan Booth

So why can't int(string) mean round toward zero?

If you want to round towards zero then you have an easy way to do it:

int(float(string))

If int(string) was changed to have this behaviour as well, then those of
who don't want any rounding wouldn't have any way to get the current
behaviour. Users may be surprised when they enter 2.1 and find the program
accepted it but didn't use the value they entered; I don't like suprising
users.

Or in more concise terms:

Explicit is better than implicit.
 
M

Mel Wilson

Why can it make this guess for "int(2.1)", then? It's got a rule for
converting floats to ints - why not use it here?

I see it more as a programmer interface issue. There are
kinds of operation that can suggest (especially in a
dynamically-typed language) that your program has gotten
away from you. Python creator(s?) could have drawn this
particular line to this side or that, but in historical fact
they drew it here. Perhaps on the principle of one
conversion at a time, please.

You could argue that unit testing, the universal solvent,
would clean up this too.

Regards. Mel.
 
S

Stephen Horne

If int(string) was changed to have this behaviour as well, then those of
who don't want any rounding wouldn't have any way to get the current
behaviour. Users may be surprised when they enter 2.1 and find the program
accepted it but didn't use the value they entered; I don't like suprising
users.

Even this is debatable, as it is possible to spot the error.
True

Or, to be sure about it...
True


You claim it's a case of "Explicit is better than implicit" but I
don't know any typecast that is explicit about what it is casting from
in any language, Python included.


One way or the other, some users get a slight extra hassle. In this
case I think Python got it right for two reasons...

1. Wanting to implicitly accept a float in a string as an integer is
relatively unusual, so better to have the small extra hassle in
this case.

2. Accidentally accepting a float in a string as an integer when you
shouldn't is a bad thing - it is usually better to get a highly
visible exception early in development rather than releasing a
program which gives bad results without warning.

But it wouldn't matter than much either way. I've used at least one
language that did the conversion in one step and that never created a
serious problem. As Mel Wilson said...

: You could argue that unit testing, the universal solvent,
: would clean up this too.
 
F

Fredrik Lundh

Joe Mason wrote:int out of this string.
So why can't int(string) mean round toward zero?

because it isn't what it means.

why so obsessed with breaking existing code? don't you have
anything better to do with your life?

</F>
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Members online

Forum statistics

Threads
473,744
Messages
2,569,484
Members
44,903
Latest member
orderPeak8CBDGummies

Latest Threads

Top