list insertion

[Randy Bush]

i am trying to insert into a singly linked list

hold = self.next
self.next = DaClass(value)
self.next.next = hold

but i suspect (from print statement insertions) that the result
is not as i expect. as the concept and code should be very
common, as i am too old for pride, i thought i would ask.

mahalo,
randy

 

[Jordan Rastrick]

What you've posted looks right, more or less.

To get any sort of meaningful feedback, you really need to post a full
version of your code, including the print statements, what's being
printed, and why you think this shows the code is not working. What
you've shown is far too little for anybody else to work with.

Regards,
Jordan


Randy Bush:

 

[Sybren Stuvel]

Randy Bush enlightened us with:

hold = self.next
self.next = DaClass(value)
self.next.next = hold

shouldn't that last line be this?
self.next.prev = hold

but i suspect (from print statement insertions) that the result is
not as i expect.

What did you expect, and what did you ovserve?

Sybren

 

[Ross Wilson]

i am trying to insert into a singly linked list

hold = self.next
self.next = DaClass(value)
self.next.next = hold

but i suspect (from print statement insertions) that the result
is not as i expect. as the concept and code should be very
common, as i am too old for pride, i thought i would ask.

mahalo,
randy

The example above looks like it would work, as long as other
stuff you _don't_ show is fine. Specifically, how do you
handle the case when the list is empty?

Better to show a more complete example with output and how that
is not what you expect.

Ross

 

[Randy Bush]

hold = self.next

shouldn't that last line be this?
self.next.prev = hold

single threaded list

What did you expect, and what did you ovserve?

i will try to distill a case

randy

 

[Bengt Richter]

i am trying to insert into a singly linked list

hold = self.next
self.next = DaClass(value)
self.next.next = hold

but i suspect (from print statement insertions) that the result
is not as i expect. as the concept and code should be very
common, as i am too old for pride, i thought i would ask.

I think you're fine. Here's some possible context for your code:
... def __init__(self, value):
... self.value = value
... self.next = None
... def values(self):
... while True:
... yield self.value
... if self.next is None: break
... self = self.next
... def insert(self, value):
... hold = self.next
... self.next = DaClass(value)
... self.next.next = hold
... return self
... def __repr__(self):
... return '<DaClass %s>'%(' -> '.join(map(repr, self.values())))
...
... <DaClass 1 -> 'a' -> 'b' -> 2>

Regards,
Bengt Richter

 

[Randy Bush]

hold = self.next

I think you're fine.

indeed. the bug was elsewhere. i got confused and tried to
look-ahead too far when i could have just recursed. i threw
away the too-clever code and replaced it with one line. i
love it when that happens.

randy