"my $x;" in while or for block?

[Am Nym]

Bad practice to declare a variable w/in a while or for block?

Is this OK?:

$ cat bar
#!/usr/bin/perl
use strict;
use warnings;

my %foo = (
bob => "green",
sue => "blue",
);

for (keys %foo)
{
my $x;
# acceptable?? (want $x to be undefined at start of each iteration)

printf "hi\n" unless(defined ($x));
$x = 1;
printf "HO\n" unless(defined ($x));

print "$_\n\n";
}
$ ./bar
hi
sue

hi
bob

 

[Am Nym]

No, absolutely not. You should declare your variables in the smallest
scope you can.

Thanks, appreciate the help.

Yes, this is good practice.

alright ;->