Nitpicking - slightly misleading traceback

[Juho Schultz]

if ((data[x][y] > 0) or
(datadict.has_key[key])):

Traceback (most recent call last):
File "reduce.py", line 524, in remove_badvalues
if ((data[x][y] > 0) or
TypeError: unsubscriptable object

However, the bug sits on the next line. I used square brackets when
normal brackets were needed - should have written datadict.has_key(key)
as the old code had datadict[key]. In the real code variable names are
so long that I must split the line. I feel the traceback is misleading.

I guess the best solution is to write code without bugs...

 

[Sybren Stuvel]

Juho Schultz enlightened us with:

However, the bug sits on the next line. [...] I feel the traceback
is misleading.

Well, the bug sits in the command starting on the line indicated.

Nitpick back: Learn about operator precedence and Python syntax rules.
You don't need so many brackets:

if data[x][y] > 0 or datadict.has_key(key):

This might even make things fit on one line again ;-)

Sybren

 

[Alex Martelli]

if data[x][y] > 0 or datadict.has_key(key):

This might even make things fit on one line again ;-)

Particularly if you code it idiomatically:

if data[x][y] > 0 or key in datadict:


Alex