passing parameter

[Eric Kaplan]

why calling PostSoapRequest will crash the program?

should I pass string* for start and end?


int post_soap_request(string start, string end)
{
string request = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>"
+ start + end;
const char* REQUEST_BODY = request.c_str();

ne_set_request_body_buffer(req, REQUEST_BODY,
strlen(REQUEST_BODY));

// some more code

return 0;
}

HRESULT PostSoapRequest(string start, string end) {
return (post_soap_request(start, end) == 0) ? S_OK : E_FAIL;
}

 

[Sharad]

why calling PostSoapRequest will crash the program?

should I pass string* for start and end?

Why? What's the intention of your program?

int post_soap_request(string start, string end)
{
string request = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>"
+ start + end;
const char* REQUEST_BODY = request.c_str();

ne_set_request_body_buffer(req, REQUEST_BODY,
strlen(REQUEST_BODY));

Where is the definition of this function? What is req?

// some more code

return 0;
}

HRESULT PostSoapRequest(string start, string end) {
return (post_soap_request(start, end) == 0) ? S_OK : E_FAIL;
}

Some tips
- Post the minimal code that compiles and demonstrates the crash. People
here can then help you better.
- Use debugger provided for your platform (seems like Windows to me)

Sharad

 

[Eric Kaplan]

the problem is parameter using "string start" instead of

int post_soap_request(string const& start, string const& end)

but i am not very sure the difference

string start / string const& start

 

[Sharad]

the problem is parameter using "string start" instead of

int post_soap_request(string const& start, string const& end)

but i am not very sure the difference

string start / string const& start

They mean pass by value, and pass by reference respectively. For user
defined types generally the latter form is preferred.
Through pass by value the caller does not get affected by the changes made
inside the function to the variable. The last statement does not hold true
for pass by reference.

Sharad

 

[Michael Oswald]

int post_soap_request(string start, string end)
{
string request = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>"
+ start + end;

I would say, this line, followed by the others is the problem:

const char* REQUEST_BODY = request.c_str();

ne_set_request_body_buffer(req, REQUEST_BODY,
strlen(REQUEST_BODY));

You take a pointer to a temporary. This is undefined behaviour.

Try this:

ne_set_request_body_buffer(req, request.c_str(),
request.size());

and remove the cont char*.

hth,
Michael