promp doesn't work

L

little susane

Hi,
I am trying to change "print results" for promt.
I don't want the output to be in HTML, it should be alert boxes.It
should be fairly easy, but every time i am changing the - >
results.innerHTML = out; it stops working.

thanks


<head>
<body>

<input id='phrase' type='text'><br>
<input type='submit' value='Click to check for palindrome'
onClick='validate();return false;'>


<span id='results'></span>
</td>
</tr>

</table>

<script type="text/javascript" language="Javascript">
<!--

var forward;
var backward;

function validate()
{
var s = "";
forward = "";
backward = "";

var p = document.getElementById( "phrase" ).value;

if ( p == null || p.length == 0 ) {
printResults(0, "A blank string is not valid. Try entering
some text.");
}

p = p.toLowerCase();

var regex = new RegExp( /[a-z]/ );



for (i = 0; i < p.length; i++) {
if ( regex.test( p.charAt( i ) ) ) {
s += p.charAt( i );
}
}

for (i = 0; i < s.length; i++) {
forward += s.charAt( i );
backward += s.charAt( s.length - 1 - i );
}

if ( forward == backward )
{
printResults( 1 );
}
else
{
printResults( 0 );
}
}

// 1 for valid, 0 for not valid

function printResults( isValid, msg )
{
var valid = "valid palindrome.";
var not_valid = "NOT a valid palindrome.";

var results = document.getElementById( "results" );
var p = document.getElementById( "phrase" ).value;

var out = "Results";

if ( isValid ) {
out += "Yup, " + p + " is a " + valid;
}
else {
out += "Nope, " + p + " is " + not_valid;
}

out += "<br>";

if ( msg != null && msg.length > 0 ) {
out += msg + "<br>";
}

if ( !isValid && forward.length > 0 && backward.length > 0 )
{
out += "[" + forward + "] (forward)<br>" +
"[" + backward + "] (backward)";
}

results.innerHTML = out;
}

function clearFields()
{
document.getElementById( "results" ).innerHTML = "";
var p = document.getElementById( "phrase" );

p.value = "";
p.focus();
}

clearFields();

//-->
</script>
</body>
</html>
 
E

Evertjan.

little susane wrote on 08 aug 2008 in comp.lang.javascript:
Hi,
I am trying to change "print results" for promt.
I don't want the output to be in HTML, it should be alert boxes.It
should be fairly easy, but every time i am changing the - >
results.innerHTML = out; it stops working.

thanks


<head>
<body>

<input id='phrase' type='text'><br>
<input type='submit' value='Click to check for palindrome'
onClick='validate();return false;'>



<span id='results'></span>
</td>
</tr>

</table>
Click to expand...

You did not declare a table.
<script type="text/javascript" language="Javascript">

<!--
Click to expand...

do not use <!-- in the 21st century.
var forward;
var backward;

function validate()
{
var s = "";
forward = "";
backward = "";

var p = document.getElementById( "phrase" ).value;

if ( p == null || p.length == 0 ) {
Click to expand...

a text input field can be zero length not null
printResults(0, "A blank string is not valid. Try entering
some text.");
}

p = p.toLowerCase();

var regex = new RegExp( /[a-z]/ );



for (i = 0; i < p.length; i++) {
if ( regex.test( p.charAt( i ) ) ) {
s += p.charAt( i );
}
}

for (i = 0; i < s.length; i++) {
forward += s.charAt( i );
backward += s.charAt( s.length - 1 - i );
}

if ( forward == backward )
{
printResults( 1 );
}
else
{
printResults( 0 );
}
}
Click to expand...

Wow, the whole ting can be done like this:

================= palindrome.html =========================
<input id='phrase' type='text'><br>
<input type='submit'
value='Click to check for palindrome'
onClick='isPalindrome();'>
<div id='results'></div>


<script type='text/javascript'>

function isPalindrome(t){
var p = document.getElementById("phrase").value;
var r = document.getElementById( "results" );
var forward = p.toLowerCase().replace(/[^a-z]/g,'');
if (forward.length>1) {
var backward = forward.split('').reverse().join('');
var pal = (forward == backward ) ?'' :'NOT ';
r.innerHTML = '"' + p + '" is ' + pal + 'a valid palindrome.';
} else {
r.innerHTML = 'String needs at least two letters.';
};
};

</script>
==========================================

// 1 for valid, 0 for not valid
Click to expand...

Why? Use true and false in js.
function printResults( isValid, msg )
Click to expand...

you did not declare msg

{
var valid = "valid palindrome.";
var not_valid = "NOT a valid palindrome.";

var results = document.getElementById( "results" );
var p = document.getElementById( "phrase" ).value;
again?

var out = "Results";

if ( isValid ) {
out += "Yup, " + p + " is a " + valid;
}
else {
out += "Nope, " + p + " is " + not_valid;
}

out += "<br>";

if ( msg != null && msg.length > 0 ) {
out += msg + "<br>";
}

if ( !isValid && forward.length > 0 && backward.length > 0 )
{
out += "[" + forward + "] (forward)<br>" +
"[" + backward + "] (backward)";
}

results.innerHTML = out;
}

function clearFields()
{
document.getElementById( "results" ).innerHTML = "";
var p = document.getElementById( "phrase" );

p.value = "";
p.focus();
}

clearFields();
Click to expand...

You clear at the loading of the page, the fileds are emptty anyway.

//-->
Click to expand...

do not use, see above.
 
L

little susane

Thx



You did not declare a table.
what for do I need to declare a table?

<script type='text/javascript'>
will do.
Click to expand...




<!-- do not use <!-- in the 21st century.
<!--ZOOM&STOP--><!---what do we use then for html comments?---->



var forward;
var backward;
Click to expand...
function validate()
{
    var s = "";
    forward = "";
    backward = "";
Click to expand...
    var p = document.getElementById( "phrase" ).value;
Click to expand...
    if ( p == null || p.length == 0 ) {
Click to expand...

a text input field can be zero length not null
        printResults(0, "A blank string is not valid.  Try entering
some text.");
    }
Click to expand...
    p = p.toLowerCase();
Click to expand...
    var regex = new RegExp( /[a-z]/ );
Click to expand...
    for (i = 0; i < p.length; i++) {
        if ( regex.test( p.charAt( i ) ) ) {
            s += p.charAt( i );
        }
    }
Click to expand...
    for (i = 0; i < s.length; i++) {
        forward += s.charAt( i );
        backward += s.charAt( s.length - 1 - i );
    }
Click to expand...
    if ( forward == backward )
    {
        printResults( 1 );
    }
    else
    {
        printResults( 0 );
    }
}
Click to expand...


Wow, the whole ting can be done like this:
Click to expand...

I am sure there are different ways to do the same thing.
You can write it in C++ and python, i guess..

From what I see ..the results of validation in your code are still
going to show in html
Not as a prompted answer.
Thanks for your comments, i did improve code a bit.



================= palindrome.html =========================
<input id='phrase' type='text'><br>
<input type='submit'
value='Click to check for palindrome'
onClick='isPalindrome();'>
<div id='results'></div>

<script type='text/javascript'>

function isPalindrome(t){
  var p = document.getElementById("phrase").value;
  var r = document.getElementById( "results" );
  var forward = p.toLowerCase().replace(/[^a-z]/g,'');
  if (forward.length>1) {
     var backward = forward.split('').reverse().join('');
     var pal = (forward == backward ) ?'' :'NOT ';
     r.innerHTML = '"' + p + '" is ' + pal + 'a valid palindrome.';
  } else {
     r.innerHTML = 'String needs at least two letters.';
  };

};

// 1 for valid, 0 for not valid
Click to expand...

Why? Use true and false in js.


function printResults( isValid, msg )
Click to expand...

you did not declare msg
{
    var valid = "valid palindrome.";
    var not_valid = "NOT a valid palindrome.";
Click to expand...
    var results = document.getElementById( "results" );
    var p = document.getElementById( "phrase" ).value;
again?



    var out = "Results";
Click to expand...
    if ( isValid ) {
        out += "Yup, " + p + " is a " + valid;
    }
    else {
        out += "Nope, " + p + " is " + not_valid;
    }
Click to expand...
    out += "<br>";
Click to expand...
    if ( msg != null && msg.length > 0 ) {
        out += msg + "<br>";
    }
Click to expand...
    if ( !isValid && forward.length > 0 && backward.length > 0 )
    {
        out += "[" + forward + "] (forward)<br>" +
            "[" + backward + "] (backward)";
    }
Click to expand...
    results.innerHTML = out;
}
Click to expand...


You clear at the loading of the page, the fileds are emptty anyway.
Click to expand...
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Similar Threads

This simple program does not work 5
I am trying to make an audio player, how do I get the selected file to be playable? 5
Reversing output of user input by using while loop... 2
An unknown bug doesn't allow the quotes app to work. What's the issue? 3
Help with code 0
Closing an overlay outside the overlay as well 1
I Need Help with making a function that draws in a canvas using location data. 1
Very Basic CC Validation Javascript 0

Members online

No members online now.
Total: 24 (members: 0, guests: 24)
Robots: 321

Forum statistics

Threads
473,755
Messages
2,569,536
Members
45,009
Latest member
GidgetGamb

Latest Threads

Top