Redundant behavior in coding guideline

Discussion in 'C Programming' started by lovecreatesbeauty, Oct 27, 2005.

  1. Some of the coding guideline are mandatory, and even the format or
    layout of the text of the source code also should be followed. There's
    plenty of codes like the following snippet.

    Do you think the "re-evaluating the previous condition" is necessary
    and should be avoided though it's one of your coding guideline? And
    yes, there's plenty of code like this in many projects.



    78 /* Error handling */
    79 if ((NULL == p_SrcNm) || (NULL == p_DestNm))
    80 {
    81 lb_RetVal = false;
    82
    83 /* some other things special here ... */
    84
    85 if (NULL == p_SrcNm) /* Re-evaluating the previous
    condition */
    86 {
    87 /* some other things special here ... */
    88
    89 ErrorEntryAdd(p_SrcNm);
    90 ErrorHandle();
    91 }
    92
    93 if (NULL == p_DestNm) /* Re-evaluating the previous
    condition */
    94 {
    95 /* some other things special here ... */
    96
    97 ErrorEntryAdd(p_DestNm);
    98 ErrorHandle();
    99 }
    100 }
     
    lovecreatesbeauty, Oct 27, 2005
    #1
    1. Advertisements

Want to reply to this thread or ask your own question?

It takes just 2 minutes to sign up (and it's free!). Just click the sign up button to choose a username and then you can ask your own questions on the forum.
Similar Threads
  1. John Salerno

    style guideline for naming variables?

    John Salerno, Mar 17, 2006, in forum: Python
    Replies:
    2
    Views:
    345
    Duncan Smith
    Mar 18, 2006
  2. Vyom

    macro style guideline

    Vyom, Nov 21, 2004, in forum: C Programming
    Replies:
    7
    Views:
    436
    Dan Pop
    Nov 23, 2004
  3. lovecreatesbeauty

    Redundant behavior in coding guideline

    lovecreatesbeauty, Oct 27, 2005, in forum: C Programming
    Replies:
    2
    Views:
    479
    Netocrat
    Oct 27, 2005
  4. lovecreatesbeauty
    Replies:
    17
    Views:
    674
    Jordan Abel
    Jan 1, 2006
  5. Paul McGuire

    Is PEP-8 a Code or More of a Guideline?

    Paul McGuire, May 27, 2007, in forum: Python
    Replies:
    52
    Views:
    1,193
    Ben Finney
    Jun 1, 2007
  6. Hendrik van Rooyen

    Re: Is PEP-8 a Code or More of a Guideline?

    Hendrik van Rooyen, May 30, 2007, in forum: Python
    Replies:
    3
    Views:
    328
    Hendrik van Rooyen
    May 31, 2007
  7. sloan

    Re: Redundant coding...

    sloan, Dec 22, 2008, in forum: ASP .Net
    Replies:
    1
    Views:
    399
  8. Louis Yeung

    Request for design guideline on parameter

    Louis Yeung, Apr 6, 2005, in forum: ASP .Net Web Services
    Replies:
    1
    Views:
    172
    Selden McCabe
    Apr 12, 2005
Loading...