regex - why won't this work?

[Trev]

Hi everyone,
I've got a very simple piece of code, and it doesn't work. I'm stumped!

var pattern1="arthur/i";

var stringtosearch = "ARTHUR and GEORGE's guest house";

pattern1.test(stringtosearch);

This should return true, but it returns false! Can anyone see what is
wrong?

TIA

Trev

 

[p.lepin]

var pattern1="arthur/i";

var stringtosearch = "ARTHUR and GEORGE's guest house";

pattern1.test(stringtosearch);

This should return true, but it returns false!

Actually, it should say something along the lines of
'pattern1.test is not a function'.

Can anyone see what is wrong?

Sure, replace

var pattern1="arthur/i";

with

var pattern1 = /arthur/i ;

 

[Trev]

Actually, it should say something along the lines of
'pattern1.test is not a function'.


Sure, replace

var pattern1="arthur/i";

with

var pattern1 = /arthur/i ;

Thanks Pavel; I've tried that but it still gives false

 

[Lee]

Trev said:

Hi everyone,
I've got a very simple piece of code, and it doesn't work. I'm stumped!

var pattern1="arthur/i";

var stringtosearch = "ARTHUR and GEORGE's guest house";

pattern1.test(stringtosearch);

This should return true, but it returns false! Can anyone see what is
wrong?

Actually, what that should do is tell you that pattern1.test is not
a function, because "arthur/i" is not a RegExp.
It's just a string that happens to end in "/i".

var pattern1=/arthur/i;
or
var pattern1 = new RegExp("arthur","i");


--

 

[shimmyshack]

var stringtosearch = "ARTHUR and GEORGE's guest house";
var reg = /arthur/i;
if ( reg.test( stringtosearch ) == true )
{
alert( 'yippee' );
}
else
{
alert( 'nope' );
}

 

[Tom Cole]

var stringtosearch = "ARTHUR and GEORGE's guest house";
var reg = /arthur/i;
if ( reg.test( stringtosearch ) == true )
{
alert( 'yippee' );
}
else
{
alert( 'nope' );
}

Trev,

Notice that the regex does not have quotes around it. If you quote it,
it is not a regex, it becomes a string. String does not have a test
method AFAIK.

HTH.

 

[Trev]

Thanks - I figured out what had gone wrong (missed out a trailing ";").
Grrrrr!

Now for my next trick:
var myURL = document.referrer;
var mySearch = /george/i;

and then do a check on mySearch.test(myURL)....should work OK.....

 

[mick white]

Thanks - I figured out what had gone wrong (missed out a trailing ";").
Grrrrr!

Now for my next trick:
var myURL = document.referrer;
var mySearch = /george/i;

and then do a check on mySearch.test(myURL)....should work OK.....

var d;
var containsGeorge=
(d=document.referrer) && /george/i.test(d);