request for another code review

Discussion in 'Python' started by Littlefield, Tyler, Sep 22, 2012.

  1. Hello all:
    I've gotten a bit farther into my python mud, and wanted to request
    another code review for style and the like. Mainly I'm concerned about
    player.py, world.py and components and other ways to handle what I'm
    trying to do.
    I didn't run pychecker just yet, so there are probably a ton of syntax
    errors; my problem was that world was importing room, and room imported
    world for functionality and that made things a mess.
    Ideas and suggestions for code cleanup and cleaner ways to do things
    would be appreciated.
    git clone https://code.google.com/p/pymud/
    Thanks,

    --
    Take care,
    Ty
    http://tds-solutions.net
    The aspen project: a barebones light-weight mud engine:
    http://code.google.com/p/aspenmud
    He that will not reason is a bigot; he that cannot reason is a fool; he that dares not reason is a slave.
     
    Littlefield, Tyler, Sep 22, 2012
    #1
    1. Advertising

  2. Littlefield, Tyler

    alex23 Guest

    On Sep 23, 6:14 am, "Littlefield, Tyler" <> wrote:
    > I've gotten a bit farther into my python mud, and wanted to request
    > another code review for style and the like.


    Are you familiar with codereview.stackexchange.com ?

    (This isn't to dissuade you from posting such requests here, just to
    help increase the chance of eyeballs on your code.)
     
    alex23, Sep 24, 2012
    #2
    1. Advertising

  3. On 9/23/2012 9:48 PM, alex23 wrote:
    > On Sep 23, 6:14 am, "Littlefield, Tyler" <> wrote:
    >> I've gotten a bit farther into my python mud, and wanted to request
    >> another code review for style and the like.

    > Are you familiar with codereview.stackexchange.com ?


    > I actually wasn't, thanks!


    > (This isn't to dissuade you from posting such requests here, just to
    > help increase the chance of eyeballs on your code.)



    --
    Take care,
    Ty
    http://tds-solutions.net
    The aspen project: a barebones light-weight mud engine:
    http://code.google.com/p/aspenmud
    He that will not reason is a bigot; he that cannot reason is a fool; he that dares not reason is a slave.
     
    Littlefield, Tyler, Sep 24, 2012
    #3
  4. On 9/23/2012 9:48 PM, alex23 wrote:
    > On Sep 23, 6:14 am, "Littlefield, Tyler" <> wrote:
    >> I've gotten a bit farther into my python mud, and wanted to request
    >> another code review for style and the like.

    > Are you familiar with codereview.stackexchange.com ?


    > I actually wasn't, thanks!


    > (This isn't to dissuade you from posting such requests here, just to
    > help increase the chance of eyeballs on your code.)



    --
    Take care,
    Ty
    http://tds-solutions.net
    The aspen project: a barebones light-weight mud engine:
    http://code.google.com/p/aspenmud
    He that will not reason is a bigot; he that cannot reason is a fool; he that dares not reason is a slave.
     
    Littlefield, Tyler, Sep 24, 2012
    #4
    1. Advertising

Want to reply to this thread or ask your own question?

It takes just 2 minutes to sign up (and it's free!). Just click the sign up button to choose a username and then you can ask your own questions on the forum.
Similar Threads
  1. Code Review Request

    , Jun 30, 2005, in forum: Java
    Replies:
    2
    Views:
    561
    Andrew Thompson
    Jun 30, 2005
  2. P Kenter

    Request for code review

    P Kenter, May 28, 2004, in forum: C++
    Replies:
    4
    Views:
    375
    P Kenter
    Jun 2, 2004
  3. Ben Hanson

    Request for Code Review

    Ben Hanson, Jul 2, 2004, in forum: C++
    Replies:
    19
    Views:
    688
    Chris Gordon-Smith
    Jul 4, 2004
  4. Debashish Chakravarty

    request for code review

    Debashish Chakravarty, Nov 18, 2003, in forum: C Programming
    Replies:
    3
    Views:
    405
    Robert Stankowic
    Nov 18, 2003
  5. www
    Replies:
    51
    Views:
    1,517
Loading...

Share This Page