Script dying at opendir()

[geek]

Hi all,

My script is dying when I try to open the current dir( at the line
opendir(DIR, "$dir").
This is the code.
==================================
my $dir = `pwd`;
my ($filename,$mydate);
print "HELLO";
opendir(DIR,"$dir") or die ("$0:can't opendir public_html: $!");
print "HELLO";
while (defined($filename = readdir(DIR))) {
print "Hello";
if ($filename =~ /\.date$/){
======================================
Any help will be great.

Thanks,
MJ

 

[jl_post]

My script is dying when I try to open the current dir
( at the line opendir(DIR, "$dir").
This is the code.
==================================
my $dir = `pwd`;
my ($filename,$mydate);
print "HELLO";
opendir(DIR,"$dir") or die ("$0:can't opendir public_html: $!");
print "HELLO";
while (defined($filename = readdir(DIR))) {
print "Hello";
if ($filename =~ /\.date$/){
======================================
Any help will be great.

Try inserting the line:

chomp($dir);

right after you assign $dir the return value of `pwd`.

-- Jean-Luc

 

[geek]

Thank you so much !! It works.

 

[A. Sinan Unur]

My script is dying when I try to open the current dir( at the line
opendir(DIR, "$dir").
This is the code.
==================================
my $dir = `pwd`;

You don't really need to spawn an external process to get the current
directory, you know.

my ($filename,$mydate);
print "HELLO";
opendir(DIR,"$dir") or die ("$0:can't opendir public_html: $!");

The die message is very misleading. You would have found out your error
if instead you had used:

opendir my $dir_h, $dir
or die "Can't opendir $dir: $!";

(Note that I removed the useless quotation marks around $dir in the
opendir call -- see perldoc -q always).

On the other hand, if all you want is to read the entries in the current
directory, you could use:

opendir my $dir_h, '.'
or die "Can't open current directory: $!";

Sinan.

 

[Chris Mattern]

Hi all,

My script is dying when I try to open the current dir( at the line
opendir(DIR, "$dir").
This is the code.
==================================
my $dir = `pwd`;

pwd returns an newline at the end...

my ($filename,$mydate);
print "HELLO";
opendir(DIR,"$dir") or die ("$0:can't opendir public_html: $!");

....which you never chomped. The opendir fails and the die kills the
script, because the directory you tried to open doesn't exist. The die
should have told you this.

print "HELLO";
while (defined($filename = readdir(DIR))) {
print "Hello";
if ($filename =~ /\.date$/){
======================================
Any help will be great.

Thanks,
MJ

--
Christopher Mattern

"Which one you figure tracked us?"
"The ugly one, sir."
"...Could you be more specific?"

 

[Tintin]

Hi all,

My script is dying when I try to open the current dir( at the line
opendir(DIR, "$dir").
This is the code.
==================================
my $dir = `pwd`;
my ($filename,$mydate);
print "HELLO";
opendir(DIR,"$dir") or die ("$0:can't opendir public_html: $!");
print "HELLO";
while (defined($filename = readdir(DIR))) {
print "Hello";
if ($filename =~ /\.date$/){
======================================
Any help will be great.

You already have answers as to why it doesn't work. I would write it as:

foreach my $file (<*.date>) {
..
}

 

[Tad McClellan]

You already have answers as to why it doesn't work. I would write it as:

foreach my $file (<*.date>) {

I would write it as:

foreach my $file (glob '*.date') {


Because I don't want to have to pause everytime I see <> in my code
in order to figure out if it is readline() or glob().

<> is always input in my programs, so there's no need to slow
down when reading it.