thc v0.3 - txt to html converter - better code?

Florian Wollenschein · May 5, 2009

Hi all,

here's some code of thc, my txt to html converter programmed with Python
and pyQT4:
-------------------------------------------------------------------------------
if self.rdioBtnTransitional.isChecked():
if self.cmboBoxLang.currentText() == "English":
file_open.write('<!DOCTYPE HTML PUBLIC "-//W3C//DTD
HTML 4.0 Transitional//EN">' + '\n')
elif self.cmboBoxLang.currentText() == "German":
file_open.write('<!DOCTYPE HTML PUBLIC "-//W3C//DTD
HTML 4.0 Transitional//DE">' + '\n')
else:
file_open.write('<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML
4.0 Strict//EN">' + '\n')
if self.cmboBoxLang.currentText() == "English":
file_open.write('<!DOCTYPE HTML PUBLIC "-//W3C//DTD
HTML 4.0 Strict//EN">' + '\n')
elif self.cmboBoxLang.currentText() == "German":
file_open.write('<!DOCTYPE HTML PUBLIC "-//W3C//DTD
HTML 4.0 Strict/DE">' + '\n')
--------------------------------------------------------------------------------

Do you have any ideas for a better code than that? Could this be done
smarter, shorter, whatever!?

Thanks in advance,
Listick
http://www.listick.org

Stefan Behnel · May 5, 2009

Florian said:
here's some code of thc, my txt to html converter programmed with Python
and pyQT4:
-------------------------------------------------------------------------------

if self.rdioBtnTransitional.isChecked():
if self.cmboBoxLang.currentText() == "English":
file_open.write('<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML
4.0 Transitional//EN">' + '\n')
elif self.cmboBoxLang.currentText() == "German":
file_open.write('<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML
4.0 Transitional//DE">' + '\n')
else:
file_open.write('<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0
Strict//EN">' + '\n')
if self.cmboBoxLang.currentText() == "English":
file_open.write('<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML
4.0 Strict//EN">' + '\n')
elif self.cmboBoxLang.currentText() == "German":
file_open.write('<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML
4.0 Strict/DE">' + '\n')
--------------------------------------------------------------------------------

Do you have any ideas for a better code than that? Could this be done
smarter, shorter, whatever!?

I assume you are referring to the code duplication above. You can build the
string incrementally instead, e.g.

language_map = {'English': 'EN', 'Deutsch': 'DE'}
strict_or_transitional = {True: 'Transitional', False: 'Strict'}

# this will raise a KeyError for unknown languages
language = language_map[ self.cmboBoxLang.currentText() ]

# this assumes that isChecked() returns True or False
spec = strict_or_transitional[self.rdioBtnTransitional.isChecked()]

doctype = '<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 %s/%s">\n' % (
spec, language)

Stefan

Richard Brodie · May 6, 2009

language_map = {'English': 'EN', 'Deutsch': 'DE'}
strict_or_transitional = {True: 'Transitional', False: 'Strict'}

# this will raise a KeyError for unknown languages
language = language_map[ self.cmboBoxLang.currentText() ]

# this assumes that isChecked() returns True or False
spec = strict_or_transitional[self.rdioBtnTransitional.isChecked()]

doctype = '<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 %s/%s">\n' % (
spec, language)

Incidentally, the language in an HTML DOCTYPE refers to the language of the DTD, not
the document. It's never correct to use //DE in an HTML page, unless you have a custom
(German) DTD. So the code can be improved further by cutting that part out.

strict_or_transitional = {True: 'Transitional', False: 'Strict'}

# this assumes that isChecked() returns True or False
spec = strict_or_transitional[self.rdioBtnTransitional.isChecked()]

doctype = '<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 %s//EN">\n' % spec

Florian Wollenschein · May 6, 2009

Richard said:
language_map = {'English': 'EN', 'Deutsch': 'DE'}
strict_or_transitional = {True: 'Transitional', False: 'Strict'}

# this will raise a KeyError for unknown languages
language = language_map[ self.cmboBoxLang.currentText() ]

# this assumes that isChecked() returns True or False
spec = strict_or_transitional[self.rdioBtnTransitional.isChecked()]

doctype = '<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 %s/%s">\n' % (
spec, language)

Click to expand...

Incidentally, the language in an HTML DOCTYPE refers to the language of the DTD, not
the document. It's never correct to use //DE in an HTML page, unless you have a custom
(German) DTD. So the code can be improved further by cutting that part out.

strict_or_transitional = {True: 'Transitional', False: 'Strict'}

# this assumes that isChecked() returns True or False
spec = strict_or_transitional[self.rdioBtnTransitional.isChecked()]

doctype = '<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 %s//EN">\n' % spec

Yes, that's true. I missed that. Thanks for the information.
And many thanks to Stefan.

Code - what could be done better?	1	May 9, 2009
What would YOU like to see in a txt to html converter?	7	May 7, 2009
In javascript, XML File Create, File Save	2	Jul 17, 2023
Help with code	0	Jun 12, 2022
Need help with programming in python for class (beginner level)	7	Nov 30, 2013
Can someone tell me if this a real tracker? Or is it one designed to show you a different message at certain times, ie. acting like one?	0	Jan 10, 2021
HTML parsing bug?	6	Jan 30, 2006
Html issue with Module::Build (Win32 ActiveState Perl)	1	Dec 20, 2009

thc v0.3 - txt to html converter - better code?

Florian Wollenschein

Stefan Behnel

Richard Brodie

Florian Wollenschein

Ask a Question

Similar Threads

Members online

Forum statistics

Latest Threads