"too many arguments" passing hash reference to subroutine

[Dean]

Running the code below I see the error:

Too many arguments for main:rint_rHoHoH at ./usenet.pl line 21, near
"$xml)"



#!/usr/bin/perl -w
use XML::Simple;

sub print_rHoHoH(){
$rHoHoH=$_[0];
for my $k1 ( sort keys %$rHoHoH ) {
print "$k1\n";

for my $k2 ( sort keys %{$rHoHoH->{ $k1 }} ) {
print "\t$k2\n";

for my $k3 ( sort keys %{$rHoHoH->{ $k1 }->{ $k2 }} ) {
print "\t\t$k3 => $rHoHoH->{ $k1 }->{ $k2 }->{ $k3 }\n";
}
}
}
}

$xml=XMLin($ARGV[0]);
print_rHoHoH($xml);



I don't understand why passing the reference to the hash in the call to the
subroutine causes the error.

If I change the last line to
do print_rHoHoH($xml);
it works, but with a warning about 'do' being deprecated.

Any insight would be much appreciated.
Thanks.

 

[Paul Lalli]

Running the code below I see the error:

Too many arguments for main:rint_rHoHoH at ./usenet.pl line 21, near
"$xml)"

#!/usr/bin/perl -w
use XML::Simple;

sub print_rHoHoH(){

You have unknowingly prototyped your subroutine to take zero arguments.
The parentheses do not belong there.

Paul Lalli

 

[kens]

Running the code below I see the error:

Too many arguments for main:rint_rHoHoH at ./usenet.pl line 21, near
"$xml)"

Whenever you see this message it means that the function/subroutine has
been
prototyped - it has a defined parameter list.

#!/usr/bin/perl -w
use XML::Simple;

sub print_rHoHoH(){

Here you defined the prototype (unintentionally I presume). The empty
parenthese indicate that this function takes no parameters.
Omit the parentheses and see how that works.

$rHoHoH=$_[0];
for my $k1 ( sort keys %$rHoHoH ) {
print "$k1\n";

for my $k2 ( sort keys %{$rHoHoH->{ $k1 }} ) {
print "\t$k2\n";

for my $k3 ( sort keys %{$rHoHoH->{ $k1 }->{ $k2 }} ) {
print "\t\t$k3 => $rHoHoH->{ $k1 }->{ $k2 }->{ $k3 }\n";
}
}
}
}

$xml=XMLin($ARGV[0]);
print_rHoHoH($xml);



I don't understand why passing the reference to the hash in the call to the
subroutine causes the error.

If I change the last line to
do print_rHoHoH($xml);
it works, but with a warning about 'do' being deprecated.

Any insight would be much appreciated.
Thanks.

HTH,
Ken

 

[Dean]

Running the code below I see the error:

Too many arguments for main:rint_rHoHoH at ./usenet.pl line 21, near
"$xml)"

Whenever you see this message it means that the function/subroutine has
been
prototyped - it has a defined parameter list.

#!/usr/bin/perl -w
use XML::Simple;

sub print_rHoHoH(){

Here you defined the prototype (unintentionally I presume). The empty
parenthese indicate that this function takes no parameters.
Omit the parentheses and see how that works.

$rHoHoH=$_[0];
for my $k1 ( sort keys %$rHoHoH ) {
print "$k1\n";

for my $k2 ( sort keys %{$rHoHoH->{ $k1 }} ) {
print "\t$k2\n";

for my $k3 ( sort keys %{$rHoHoH->{ $k1 }->{ $k2 }} ) {
print "\t\t$k3 => $rHoHoH->{ $k1 }->{ $k2 }->{ $k3 }\n";
}
}
}
}

$xml=XMLin($ARGV[0]);
print_rHoHoH($xml);



I don't understand why passing the reference to the hash in the call to the
subroutine causes the error.

If I change the last line to
do print_rHoHoH($xml);
it works, but with a warning about 'do' being deprecated.

Any insight would be much appreciated.
Thanks.

HTH,
Ken

Many Thanks. All I can say is I'd been doing some php prior to this and
completely overlooked it :-/