va_start and references

[John Harrison]

Is the following code OK?

#include <stdarg.h>

void func(const X& x)
{
va_list args;
va_start(args, x);
funcv(x, args);
va_end(args);
}

void funcv(const X& x, va_list args)
{
// ...
}

In other words is it OK to use va_start on an parameter that is a reference?
I can't see anything that says it isn't, nor can I see why it shouldn't work
from looking at the definition of va_start in my compiler (VC++ 7). But I
get memory access errors in funcv, which only go away when I change the type
of the parameter to func from const X& to X.

john

 

[Pete Becker]

In other words is it OK to use va_start on an parameter that is a reference?

No. 18.7/3.

 

[John Harrison]

reference?

No. 18.7/3.

OK thanks, I'd of found that reference if va_start had been in the index of
the standard.

john

 

[red floyd]

OK thanks, I'd of found that reference if va_start had been in the index of
the standard.

john

Also, try using <cstdarg> instead of <stdarg.h>

 

[John Harrison]

Also, try using <cstdarg> instead of <stdarg.h>

Why?

john

 

[red floyd]

It was my impression that the <XXX.h> C90 headers were deprecated in
favor of the <cXXX> headers in C++98.

 

[Ron Natalie]

It was my impression that the <XXX.h> C90 headers were deprecated in
favor of the <cXXX> headers in C++98.

Deprecation has no real meaning however.