childnodes to attach function

windandwaves · Mar 4, 2007

Hi Folk

I want to add an "onClick" function to the radio boxes, but I am
having trouble. Can you help me

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://
www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=iso-8859-1" />
<title>leetMachines</title>
<style>
body {width: 600px; margin-left: auto; margin-right: auto;}
label {display: block;}
h2 {color: green;}
p.moreinfo {float: right;}
d.options {clear: right;}
h2, p, div {margin: 0px; padding: 0px;}
</style>
<script type="text/javascript">
function starter(elname) {
obj = document.getElementById(elname);
addclicks(obj);
}

function addclicks() {//gets all variables from a form
for (i=0; i < obj.childNodes.length; i++) {
var newobj = obj.childNodes;
tgname = newobj.tagName
if(tgname) {
if (tgname == "INPUT" || tgname == "input") {
newObj.onClick = gonow;
}
}
addclicks(newobj);
}
}

function gonow() {
alert("click");
}

</script>
</head>
<body onload="starter('former');">
<form method="post" action="" name="former" id="former" onclick="">
<h2>Choose below</h2>
<div class="options" id="item1-options">
<label for="item1"><input type="radio" name="item1" value="0"
id="item1-option0" />option 1</label>
<label for="item1"><input type="radio" name="item1" value="1"
id="item1-option1" />option 2</label>
<label for="item1"><input type="radio" name="item1" value="2"
id="item1-option2" />option 3</label>
</div>
</form>
</body>
</html>

RobG · Mar 4, 2007

Hi Folk

I want to add an "onClick" function to the radio boxes, but I am
having trouble. Can you help me

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

There have been many long discussions on whether pages should use
XHTML or HTML, none have shown any significant benefit to using XHTML
on the web. The disadvantages are great, just use HTML unless you
have a really good reason to use XHTML.

<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=iso-8859-1" />
<title>leetMachines</title>
<style>
body {width: 600px; margin-left: auto; margin-right: auto;}
label {display: block;}
h2 {color: green;}
p.moreinfo {float: right;}
d.options {clear: right;}
h2, p, div {margin: 0px; padding: 0px;}
</style>
<script type="text/javascript">
function starter(elname) {
obj = document.getElementById(elname);

Better to keep variables local with 'var':

var obj = document.getElementById(elname);

addclicks(obj);

}

function addclicks() {//gets all variables from a form

You pass a reference to obj when you call the function, but don't
assign it to a local variable - you depend on its being a global
variable. Much better to give it a local variable:

function addclicks(obj) {

for (i=0; i < obj.childNodes.length; i++) {

Counters should never be allowed to become global:

for (var i=0, len=obj.childNodes.length; i<len; i++) {

var newobj = obj.childNodes;
tgname = newobj.tagName

windandwaves · Mar 4, 2007

Hi Folk

Click to expand...

I want to add an "onClick" function to the radio boxes, but I am
having trouble. Can you help me

Click to expand...

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

Click to expand...

There have been many long discussions on whether pages should use
XHTML or HTML, none have shown any significant benefit to using XHTML
on the web. The disadvantages are great, just use HTML unless you
have a really good reason to use XHTML.

<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=iso-8859-1" />
<title>leetMachines</title>
<style>
body {width: 600px; margin-left: auto; margin-right: auto;}
label {display: block;}
h2 {color: green;}
p.moreinfo {float: right;}
d.options {clear: right;}
h2, p, div {margin: 0px; padding: 0px;}
</style>
<script type="text/javascript">
function starter(elname) {
obj = document.getElementById(elname);

Click to expand...

Better to keep variables local with 'var':

var obj = document.getElementById(elname);

addclicks(obj);

function addclicks() {//gets all variables from a form

Click to expand...

You pass a reference to obj when you call the function, but don't
assign it to a local variable - you depend on its being a global
variable. Much better to give it a local variable:

function addclicks(obj) {

for (i=0; i < obj.childNodes.length; i++) {

Click to expand...

Counters should never be allowed to become global:

for (var i=0, len=obj.childNodes.length; i<len; i++) {

var newobj = obj.childNodes;
tgname = newobj.tagName

Click to expand...

var tgname = newobj.tagName

if(tgname) {
if (tgname == "INPUT" || tgname == "input") {

Click to expand...

Usually:

if (tgname.toLowerCase() == 'input') {

newObj.onClick = gonow;
}
}
addclicks(newobj);

Click to expand...

This will recursively call addclicks. An input can't have any
children, so it's pointless.

If you only want to add onclick's to inputs, why not use
getElementsByTagName?

function addclicks(obj){
var nodes = obj.getElementsByTagName('input');
var i = nodes.length;
while (i--){
nodes.onclick = gonow;
}
}

Hi Rob

You are a legend. Amazing!

Cheers, Nicolaas

Positioning CSS components	1	Nov 16, 2023
I dont get this. Please help me!!	2	Jan 24, 2023
I need help making a zooming function	11	Dec 14, 2021
Why doesn't the function get called?	1	Nov 20, 2023
"input-group-text" help	7	Aug 10, 2023
How can I remove the specific error message after regex validation is done?	1	Jan 25, 2023
I Need Help with making a function that draws in a canvas using location data.	1	Dec 17, 2021
Check forms With JavaScript	1	Mar 28, 2023

childnodes to attach function

windandwaves

RobG

windandwaves

Ask a Question

Similar Threads

Members online

Forum statistics

Latest Threads