i'm stupid see this code

N

nalbayo

this code i wrote....completly dirty code i think
can i make this code more simple and easy?
........&&

protected void AddUploadImageButton_Click(object sender,
ImageClickEventArgs e)
{
int fileUploadCount =
int.Parse(Request.Cookies["Upload"]["UploadCount"].ToString());
if (fileUploadCount != 10)
Response.Cookies["Upload"]["UploadCount"] =
string.Format("{0}",++fileUploadCount);

switch (fileUploadCount)
{
case 1:
FileUpload1.Visible = true;
break;
case 2:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
break;
case 3:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
break;
case 4:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
break;
case 5:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
break;
case 6:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
break;
case 7:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
FileUpload7.Visible = true;
break;
case 8:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
FileUpload7.Visible = true;
FileUpload8.Visible = true;
break;
case 9:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
FileUpload7.Visible = true;
FileUpload8.Visible = true;
FileUpload9.Visible = true;
break;
case 10:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
FileUpload7.Visible = true;
FileUpload8.Visible = true;
FileUpload9.Visible = true;
FileUpload10.Visible = true;
break;
}
 
J

Jim Suruda

Nalbayo-

That does look like it could be shorter. How about something like such:

int fileUploadCount = 4; // or whatever
ImageButton[] buttons = {this.FileUpLoad1, this.FileUpLoad2, this.FileUpLoad3,
this.FileUpLoad4, this.FileUpLoad5, this.FileUpLoad6, this.FileUpLoad7};

for (int i=0; i<fileUploadCount; i++)
buttons.Visible = true;

:)

Jim Suruda
 
G

Guest

Why don't you try:

FileUpload1.Visible = fileUploadCount >= 1;
FileUpload2.Visible = fileUploadCount >= 2;
FileUpload3.Visible = fileUploadCount >= 3;
FileUpload4.Visible = fileUploadCount >= 4;
FileUpload5.Visible = fileUploadCount >= 5;
FileUpload6.Visible = fileUploadCount >= 6;
FileUpload7.Visible = fileUploadCount >= 7;
FileUpload8.Visible = fileUploadCount >= 8;
FileUpload9.Visible = fileUploadCount >= 9;
FileUpload10.Visible = fileUploadCount >= 10;

and that string.Format isn't necessarry, just use
(fileUploadCount++).ToString().

Tim
 
G

Guest

There is a way to do it in a loop, but that is actually inefficient (even
though it would look cool :)

Tim
 
N

nalbayo

I changed my code,,Why am i think about this ?? lol

it's really helpful to me...really thank you for your answer..



FileUpload[] fileUploadObject = {
FileUpload1,
FileUpload2,
FileUpload3,
FileUpload4,
FileUpload5,
FileUpload6,
FileUpload6,
FileUpload7,
FileUpload8,
FileUpload9,
FileUpload10
};

for (int i=0; i<fileUploadCount; i++)
fileUploadObject.Visible = true;


Jim Suruda said:
Nalbayo-

That does look like it could be shorter. How about something like such:

int fileUploadCount = 4; // or whatever
ImageButton[] buttons = {this.FileUpLoad1, this.FileUpLoad2,
this.FileUpLoad3,
this.FileUpLoad4, this.FileUpLoad5, this.FileUpLoad6, this.FileUpLoad7};

for (int i=0; i<fileUploadCount; i++)
buttons.Visible = true;

:)

Jim Suruda


this code i wrote....completly dirty code i think
can i make this code more simple and easy?
.......&&

protected void AddUploadImageButton_Click(object sender,
ImageClickEventArgs e)
{
int fileUploadCount =
int.Parse(Request.Cookies["Upload"]["UploadCount"].ToString());
if (fileUploadCount != 10)
Response.Cookies["Upload"]["UploadCount"] =
string.Format("{0}",++fileUploadCount);

switch (fileUploadCount)
{
case 1:
FileUpload1.Visible = true;
break;
case 2:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
break;
case 3:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
break;
case 4:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
break;
case 5:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
break;
case 6:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
break;
case 7:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
FileUpload7.Visible = true;
break;
case 8:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
FileUpload7.Visible = true;
FileUpload8.Visible = true;
break;
case 9:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
FileUpload7.Visible = true;
FileUpload8.Visible = true;
FileUpload9.Visible = true;
break;
case 10:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
FileUpload7.Visible = true;
FileUpload8.Visible = true;
FileUpload9.Visible = true;
FileUpload10.Visible = true;
break;
}
Click to expand...
Click to expand...
 
N

nalbayo

it's also cool code ...i think
but fileUploadCount >= 1..2...3... parts are little difficult to
understand...lol
i understood but little difficult..to see...it
but...good idea~~ thanks

timkling said:
Why don't you try:

FileUpload1.Visible = fileUploadCount >= 1;
FileUpload2.Visible = fileUploadCount >= 2;
FileUpload3.Visible = fileUploadCount >= 3;
FileUpload4.Visible = fileUploadCount >= 4;
FileUpload5.Visible = fileUploadCount >= 5;
FileUpload6.Visible = fileUploadCount >= 6;
FileUpload7.Visible = fileUploadCount >= 7;
FileUpload8.Visible = fileUploadCount >= 8;
FileUpload9.Visible = fileUploadCount >= 9;
FileUpload10.Visible = fileUploadCount >= 10;

and that string.Format isn't necessarry, just use
(fileUploadCount++).ToString().

Tim


nalbayo said:
this code i wrote....completly dirty code i think
can i make this code more simple and easy?
........&&

protected void AddUploadImageButton_Click(object sender,
ImageClickEventArgs e)
{
int fileUploadCount =
int.Parse(Request.Cookies["Upload"]["UploadCount"].ToString());
if (fileUploadCount != 10)
Response.Cookies["Upload"]["UploadCount"] =
string.Format("{0}",++fileUploadCount);

switch (fileUploadCount)
{
case 1:
FileUpload1.Visible = true;
break;
case 2:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
break;
case 3:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
break;
case 4:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
break;
case 5:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
break;
case 6:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
break;
case 7:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
FileUpload7.Visible = true;
break;
case 8:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
FileUpload7.Visible = true;
FileUpload8.Visible = true;
break;
case 9:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
FileUpload7.Visible = true;
FileUpload8.Visible = true;
FileUpload9.Visible = true;
break;
case 10:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
FileUpload7.Visible = true;
FileUpload8.Visible = true;
FileUpload9.Visible = true;
FileUpload10.Visible = true;
break;
}
Click to expand...
Click to expand...
 
L

Lau Lei Cheong

If you have problem, why don't you change a bit to make it clearer? :p

FileUpload1.Visible = (fileUploadCount >= 1);

nalbayo said:
it's also cool code ...i think
but fileUploadCount >= 1..2...3... parts are little difficult to
understand...lol
i understood but little difficult..to see...it
but...good idea~~ thanks

timkling said:
Why don't you try:

FileUpload1.Visible = fileUploadCount >= 1;
FileUpload2.Visible = fileUploadCount >= 2;
FileUpload3.Visible = fileUploadCount >= 3;
FileUpload4.Visible = fileUploadCount >= 4;
FileUpload5.Visible = fileUploadCount >= 5;
FileUpload6.Visible = fileUploadCount >= 6;
FileUpload7.Visible = fileUploadCount >= 7;
FileUpload8.Visible = fileUploadCount >= 8;
FileUpload9.Visible = fileUploadCount >= 9;
FileUpload10.Visible = fileUploadCount >= 10;

and that string.Format isn't necessarry, just use
(fileUploadCount++).ToString().

Tim


nalbayo said:
this code i wrote....completly dirty code i think
can i make this code more simple and easy?
........&&

protected void AddUploadImageButton_Click(object sender,
ImageClickEventArgs e)
{
int fileUploadCount =
int.Parse(Request.Cookies["Upload"]["UploadCount"].ToString());
if (fileUploadCount != 10)
Response.Cookies["Upload"]["UploadCount"] =
string.Format("{0}",++fileUploadCount);

switch (fileUploadCount)
{
case 1:
FileUpload1.Visible = true;
break;
case 2:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
break;
case 3:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
break;
case 4:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
break;
case 5:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
break;
case 6:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
break;
case 7:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
FileUpload7.Visible = true;
break;
case 8:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
FileUpload7.Visible = true;
FileUpload8.Visible = true;
break;
case 9:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
FileUpload7.Visible = true;
FileUpload8.Visible = true;
FileUpload9.Visible = true;
break;
case 10:
FileUpload1.Visible = true;
FileUpload2.Visible = true;
FileUpload3.Visible = true;
FileUpload4.Visible = true;
FileUpload5.Visible = true;
FileUpload6.Visible = true;
FileUpload7.Visible = true;
FileUpload8.Visible = true;
FileUpload9.Visible = true;
FileUpload10.Visible = true;
break;
}
Click to expand...
Click to expand...
Click to expand...
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Similar Threads

A problem of dynamically creating a control 3
Something is wrong 1
My Switch statement get stuck on the last statement 5
Code was not Working Please Help 1
Qsort() messing with my entire Code 0
GET NEIL DEGRASSES TYSON, I ripped a hole with this one... 0
cannot retrieve dropdownlist selected value 3
Qsort() is messing with my entire Code!!! 0

Members online

Total: 30 (members: 2, guests: 28)
Robots: 180

Forum statistics

Threads
473,756
Messages
2,569,540
Members
45,025
Latest member
KetoRushACVFitness

Latest Threads

Top