reference or pointer in parameter list - which is prefereable?

[Maksim Kasimov]

i have two functions and both of them are to make changes into object field or get some results into caller function:

void FooFunc1(FooClass& a)
{ ...

void FooFunc2(FooClass* a)
{ ...

or

void FooFunc3(int& a)
{ ...

void FooFunc4(int* a)
{ ...


in what cases it is prefereble to use reference or pointer in parameter list?

many thanks.

 

[Ian Collins]

i have two functions and both of them are to make changes into object
field or get some results into caller function:

void FooFunc1(FooClass& a)
{ ...

void FooFunc2(FooClass* a)
{ ...

or

void FooFunc3(int& a)
{ ...

void FooFunc4(int* a)
{ ...


in what cases it is prefereble to use reference or pointer in parameter
list?

I'd say neither. I'd use a smart pointer type, but that's my style.

There are may arguments for and against both, look back through the
group archives.

 

[Roland Pibinger]

I'd say neither. I'd use a smart pointer type, but that's my style.

"Smart" pointers should _never_ be used as function parameters!

Best wishes,
Roland Pibinger

 

[Roland Pibinger]

i have two functions and both of them are to make changes into object field or get some results into caller function:

void FooFunc1(FooClass& a)
{ ...

void FooFunc2(FooClass* a)
{ ...

or

void FooFunc3(int& a)
{ ...

void FooFunc4(int* a)
{ ...


in what cases it is prefereble to use reference or pointer in parameter list?

Use references when you can pointers when you must (IIRC, this is a
FAQ). Pointers are only necessary when you also need to pass 0 (NULL)
to the function. The latter probably indicates a design problem
anyway.

Best wishes,
Roland Pibinger

 

[Ian Collins]

"Smart" pointers should _never_ be used as function parameters!

Why?

 

[Squeamizh]

I'd say neither. I'd use a smart pointer type, but that's my style.

What if the parameter isn't dynamically allocated?

 

[Ian Collins]

What if the parameter isn't dynamically allocated?

Then you can't pass it.

I guess I've been working in an environment where every object is some
form of smart pointer, I'd overlooked the obvious!

I tend to faviour references in the general case.