beginner question

beenben · Mar 2, 2008

when I just have the alert on onload it works but I can't get it to
work when I've also got an alert on unLoad. What am I doing wrong??

<?xml version="1.0" encoding="ISO-8859-1"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="de" lang="de">

<head>
<script type="text/javascript">
function surveyQ(){alert("Please take our Customer Service Survey.");}
return true;

function thanks(){alert("We appreciate you opinions!"); } return true;

</head>

<body>
onload="surveyQ()";

onUnload="thanks()";

</body>

</script>
</html>

Evertjan. · Mar 2, 2008

beenben wrote on 02 mrt 2008 in comp.lang.javascript:

when I just have the alert on onload it works but I can't get it to
work when I've also got an alert on unLoad. What am I doing wrong??

[please leave al the crap out that has nothing to do with your Q]

function surveyQ(){alert("Please take our Customer Service Survey.");}
return true;

function thanks(){alert("We appreciate you opinions!"); } return true;

Thanks to your bad visual formatting you do not see your mistakes.

I will reformat:

function surveyQ() {
alert("Please take our Customer Service Survey.");
};
return true;

function thanks() {
alert("We appreciate you opinions!");
};
return true;

Looking for the error text and error line number can help you
if you do not see the bugs yet.

Thomas 'PointedEars' Lahn · Mar 2, 2008

beenben said:
when I just have the alert on onload it works but I can't get it to
work when I've also got an alert on unLoad. What am I doing wrong??

Maybe using `onUnload' instead of `onunload'. XHTML is case-sensitive.

[...]
<body>
onload="surveyQ()";

onUnload="thanks()";

Maybe using `onUnload' instead of `onunload'. XHTML is fully case-sensitive.

See also:

http://www.w3.org/TR/xhtml1/
http://hsivonen.iki.fi/xhtml-the-point/
http://hixie.ch/advocacy/xhtml
http://www.spartanicus.utvinternet.ie/no-xhtml.htm

PointedEars

Mango · Mar 2, 2008

Hi

Great start; you are almost there. A few notes.

1) You have a couple of "return true;" that are outside your functions.
2) Your closing </script> tag was in the wrong place. <body> cannot be
inside <script>. Make sure to always close tags in the reverse order
you open them.
3) Your onload and onunload attributes were in the wrong place. Also
note that for XHTML, attributes should be in lower case. Use onunload
instead of onUnload.

This worked for me:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="de" lang="de">
<head>
<script type="text/javascript">
function surveyQ(){
alert("Please take our Customer Service Survey.");
}
function thanks() {
alert("We appreciate you opinions!");
}
</script>
<title>Test page</title>
</head>
<body onload="surveyQ();" onunload="thanks();">
<p>Content goes here...</p>
</body>
</html>

Cheers,
Mango

Mango · Mar 2, 2008

Evertjan. said:
[please leave al the crap out that has nothing to do with your Q]

Actually, the "crap" had everything to do with his question. For

Thanks to your bad visual formatting you do not see your mistakes.

I was able to read it perfectly well.

I will reformat:

It still doesn't work

He asked a perfectly reasonable question. If
you're going to mock him, at least do it right

Evertjan. · Mar 2, 2008

Mango wrote on 02 mrt 2008 in comp.lang.javascript:

Evertjan. said:
Evertjan. said:

[please leave al the crap out that has nothing to do with your Q]

Click to expand...

Actually, the "crap" had everything to do with his question. For
instance, he left some attributes outside of the <body> tag, which we
would not have known if he posted only the Javascript.

No, that part was not the crap.

I was able to read it perfectly well.

It still doesn't work He asked a perfectly reasonable question. If
you're going to mock him, at least do it right

Beside the point,because:
Reformatting shows the error, reformatting is not correcting.
I am not mocking him, though I am tempted to mock you.

I am showing him a way to find the error himself by just looking at the
code, you obviously did not see it.

DOCTYPE related question	7	Feb 10, 2012
XHTML - how extend/create ELEMENT body in my DTD?	0	Oct 29, 2019
JS - prevent keypress bubbling to child with listener on parent?	8	Oct 11, 2011
Style sheet question	3	May 24, 2012
Internet Explorer XHTML window.onload issue	9	Dec 18, 2007
is 'this' always defined for functions?	13	Aug 26, 2008
IE shows false and Firefox shows true	3	Jul 10, 2009
How to get the height of an element in ie?	2	Jan 17, 2008

beginner question

beenben

Evertjan.

Thomas 'PointedEars' Lahn

Mango

Mango

Evertjan.

Ask a Question

Similar Threads

Members online

Forum statistics

Latest Threads