c++ objects

[Amira]

Following is my header file:


#ifndef PROTEIN_
#define PROTEIN_

#include <iostream>
#include <fstream>
#include <string>

using namespace std;

class Protein { // class Protein

private:
std::string protName_;
std::string molWeight_;
std::string protFamily_;
public:
ProtWrite(int, int, int);
~ProtWrite();

ProtRead(int, int, int);
~ProtRead();

};

#endif //PROTEIN_


++++++++++++The cpp file is as follows:

#include <string>
#include <fstream>
#include "protein.h"
using namespace std;
//using std::cout;


Protein:rotWrite(int protName_, int molWeight_, int protFamily_)
{
ofstream myfile;
myfile.open ("protein.txt");
myfile << "<Protein>\n" << " <molWeight>" << molWeight_ << "</
molWeight>"
<< "\n</Protein>" << endl;
myfile.close();
};


int main(){

Protein prt;


std::cout << "Please enter the name: ";
std::getline(std::cin, prt.protName_);

std::cout << "Please enter the weight: ";
std::getline(std::cin, molWeight_);

std::cout << "Please enter the family: ";
std::getline(std::cin, protFamily_);


return 0;
}

Now, when I try to compile the code I get the error 'std::string
Protein:rotName_' is private. Somebody and advice?

Cheers,
Paul

 

[Andre Kostur]

Following is my header file:


#ifndef PROTEIN_
#define PROTEIN_

#include <iostream>
#include <fstream>
#include <string>

using namespace std;

class Protein { // class Protein

private:
std::string protName_;
std::string molWeight_;
std::string protFamily_;
public:
ProtWrite(int, int, int);
~ProtWrite();

ProtRead(int, int, int);
~ProtRead();

};

#endif //PROTEIN_


++++++++++++The cpp file is as follows:

#include <string>
#include <fstream>
#include "protein.h"
using namespace std;
//using std::cout;


Protein:rotWrite(int protName_, int molWeight_, int
protFamily_) {
ofstream myfile;
myfile.open ("protein.txt");
myfile << "<Protein>\n" << " <molWeight>" <<
molWeight_ << "</
molWeight>"
<< "\n</Protein>" << endl;
myfile.close();
};


int main(){

Protein prt;


std::cout << "Please enter the name: ";
std::getline(std::cin, prt.protName_);

std::cout << "Please enter the weight: ";
std::getline(std::cin, molWeight_);

std::cout << "Please enter the family: ";
std::getline(std::cin, protFamily_);


return 0;
}

Now, when I try to compile the code I get the error 'std::string
Protein:rotName_' is private. Somebody and advice?

Which part of "'std::string Protein:rotName_' is private" don't you
understand? (Also, most compilers will tell you which line of your file
it's complaining about...)

If you look at your class, protName_ is declared as private.

 

[Amira]

Hi Andre!,

Which part of "'std::string Protein:rotName_' is private" don't you
understand? (Also, most compilers will tell you which line of your file
it's complaining about...)

If you look at your class, protName_ is declared as private.

thanks a lot for your prompt reply. I have now fixed that problem but
another one occured. I described it in the new posting. Any help??

Cheers, paul

 

[red floyd]

Following is my header file:


#ifndef PROTEIN_
#define PROTEIN_

#include <iostream>
#include <fstream>
#include <string>

using namespace std;

This line is bad. Very bad. While it's legal, you should never put a
"using namespace" declaration in a header file. Period.

 

[Pronova]

In the class Protein, you declared protName_ as private. This means that
you cannot access it outside of Protein. You would need to either make it
public or declare a public accessor method.

If you're going to make a class only just to encapsulate member variables
and nothing else, I would advise making these public. Otherwise, you would
have to make endless access methods for every member variable. A struct
might be the better choice if this object doesn't do anything but store
data.