(char *) to (const char *) is also dangerous but allowed?

  • Thread starter lovecreatesbea...
  • Start date
L

lovecreatesbea...

C stops the conversion from (char **) to (const char **). c-faq.com
sec 11.10 has explanation on this point. But, for example, even the
conversion from (char *) to (const char *) brings the same dangerous
as in the previous conversion. Why the latter simple but dangerous one
is allowed in C?

$ cat f1.c
int main(void)
{
const char c = 'a';
char *p;
const char *cp = p;

cp = &c;
*p = 'x'; /*line 8*/

return 0;
}
$ cc -Aa -g f1.c
$ ./a.out
Bus error(coredump)
$ gdb -q ./a.out core
Core was generated by `a.out'.
Program terminated with signal 10, Bus error.

warning: The shared libraries were not privately mapped; setting a
breakpoint in a shared library will not work until you rerun the
program.

#0 0x29d4 in main () at f1.c:8
8 *p = 'x';
(gdb) quit
$
 
C

christian.bau

$ cat f1.c
int main(void)
{
const char c = 'a';
char *p;
const char *cp = p;

cp = &c;
*p = 'x'; /*line 8*/

return 0;}

That crash has nothing to do with const char*. Remove all the lines
involving cp and c, and the program will crash just the same. This is
just a case of stupid programmer error.
 
J

Jens Thoms Toerring

C stops the conversion from (char **) to (const char **). c-faq.com
sec 11.10 has explanation on this point. But, for example, even the
conversion from (char *) to (const char *) brings the same dangerous
as in the previous conversion. Why the latter simple but dangerous one
is allowed in C?
$ cat f1.c
int main(void)
{
const char c = 'a';
char *p;
const char *cp = p;
cp = &c;
*p = 'x'; /*line 8*/

There isn't any issue with conversions between char and const char
at all here. The simple and only problem is that you use a random
address to store a value in. 'p' is never initialized, so there's
no memory assigned to it that you own. Instead 'p' will point to
some random position in memory. But you try to store a value at
that memory location anyway. This invokes undefined behaviour and
from now on anything can happen. You may get a segmentation fault,
a bus error, it may even appear to work or the (in)famous nasal
daemons could make their appearance.

Regards, Jens
 
M

Malcolm McLean

C stops the conversion from (char **) to (const char **). c-faq.com
sec 11.10 has explanation on this point. But, for example, even the
conversion from (char *) to (const char *) brings the same dangerous
as in the previous conversion. Why the latter simple but dangerous one
?
It isn't dangerous to cast a pointer to a const *, as long as the data is
set up correctly. Going in reverse from const * to a plain pointer is
potentially dangerous, and is only allowed because of weaknesses in the
language arising from the fact that const was an afterthought.
 
L

lovecreatesbea...

There isn't any issue with conversions between char and const char
at all here. The simple and only problem is that you use a random
address to store a value in. 'p' is never initialized, so there's
no memory assigned to it that you own. Instead 'p' will point to
some random position in memory. But you try to store a value at
that memory location anyway. This invokes undefined behaviour and
from now on anything can happen. You may get a segmentation fault,
a bus error, it may even appear to work or the (in)famous nasal
daemons could make their appearance.

I'm sorry to make a wrong example. The pointer p wasn't initiated. p
and cp ever pointed to a same address, cp was re-assigned, p wasn't
changed and had a random address all the time. I understand it now.
Thank you for your time.
 
M

Martin Ambuhl

Why the latter simple but dangerous one
is allowed in C?

Because the programmer is responsible for making sure that pointers have
legal values. Your program self-destructs for a reason completely
unrelated to the const-ness of the chars and and pointers-to-char.
$ cat f1.c
int main(void)
{
const char c = 'a';
char *p;

p is not initialized.
const char *cp = p;

p is still not initialized, and the value of cp is indeterminate,

cp = &c;
*p = 'x'; /*line 8*/
^^
dereferencing p, which has never been given a value.
 
V

Vallabha

C stops the conversion from (char **) to (const char **). c-faq.com
sec 11.10 has explanation on this point. But, for example, even the
conversion from (char *) to (const char *) brings the same dangerous
as in the previous conversion. Why the latter simple but dangerous one
is allowed in C?

$ cat f1.c
int main(void)
{
const char c = 'a';
char *p;
const char *cp = p;

cp = &c;
*p = 'x'; /*line 8*/

return 0;}

$ cc -Aa -g f1.c
$ ./a.out
Bus error(coredump)
$ gdb -q ./a.out core
Core was generated by `a.out'.
Program terminated with signal 10, Bus error.

warning: The shared libraries were not privately mapped; setting a
breakpoint in a shared library will not work until you rerun the
program.

#0 0x29d4 in main () at f1.c:8
8 *p = 'x';
(gdb) quit
$

It's due to programming error.

However, you can change the value of const char using a pointer.

Ex:

#include <stdio.h>


int main ()
{
const char c = 'c';
char *p = &c;
*p = 'x';
printf("%c \n", c);
return 0;
}

However compiler thorws the warning of using a char pointer to a const
character.

$>cc del.c
"del.c", line 7: warning: assignment type mismatch:
pointer to char "=" pointer to const char

Cheers
-Vallabha
 
F

Flash Gordon

Vallabha wrote, On 11/04/07 06:30:

However, you can change the value of const char using a pointer.

You can attempt to, but it invokes undefined behaviour which means that
anything can happen, including it causing your in-laws to move in
permanently. The most likely results are either the program crashing or
working as you expect. Don't do it.
Ex:

#include <stdio.h>


int main ()

Better to be explicit
int main(void)
{
const char c = 'c';
char *p = &c;
*p = 'x';
printf("%c \n", c);
return 0;
}

However compiler thorws the warning of using a char pointer to a const
character.

Some compilers do, but this is not required and not all compiler will.
 
R

Richard Heathfield

Flash Gordon said:
[...] it invokes undefined behaviour which means
that anything can happen, including it causing your in-laws to move in
permanently.

The UB war just got a little bit nastier.
 
C

Charlton Wilbur

RH> Flash Gordon said:
>> [...] it invokes undefined behaviour which means that anything
>> can happen, including it causing your in-laws to move in
>> permanently.

RH> The UB war just got a little bit nastier.

There's a reason the DS9000 was a commercial failure.

Charlton
 
D

David Thompson

Vallabha wrote, On 11/04/07 06:30:

Some compilers do, but this is not required and not all compiler will.

Well, removing const or volatile qualification from a pointer is a
constraint violation, and conforming implementation is required to
issue a diagnostic. Whether that diagnostic is a warning, and how well
it identifies the problem, is 'only' Quality of Implementation.

- formerly david.thompson1 || achar(64) || worldnet.att.net
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Members online

Forum statistics

Threads
473,769
Messages
2,569,580
Members
45,054
Latest member
TrimKetoBoost

Latest Threads

Top