Closing Database issue

[francan00]

I have a method that inserts data into my Oracle 9i database with no
problems or Database closing issues:

CODE
public class MainClass
{

public PreparedStatement preparer;
public Connection connection;

public MainClass()
{
connection = new DbConnectionClass().getConnection();
}

public int inserter(Beann abc)
{
int dat = 0;
try
{
preparer = connection.prepareStatement("insert into abTable
(one,two) values (?,?)");
preparer.setString(1, abc.getOne());
preparer.setString(2, abc.getTwo());
preparer.executeUpdate();
}
catch(Exception e)
{
e.printStackTrace();
}
return dat;
}

public int matcher(Beann abc)
{
try
{
inserter(abc);
}
catch(Exception e)
{
e.printStackTrace();
}
finally
{
//close the ResultSet ....
//close the Statement ....
//close the Connection ....
}
}

Now when I put the method (inserter) in another class called
OtherClass, it does insert the data but now I have database closing
issues:


CODE
public class OtherClass
{
....
public int inserter(Beann abc)
{
int dat = 0;
try
{
preparer = connection.prepareStatement("insert into abTable
(one,two) values (?,?)");
preparer.setString(1, abc.getOne());
preparer.setString(2, abc.getTwo());
preparer.executeUpdate();
}
catch(Exception e)
{
e.printStackTrace();
}
return dat;
}
.....



CODE
public class MainClass
{

public PreparedStatement preparer;
public Connection connection;

public MainClass()
{
connection = new DbConnectionClass().getConnection();
}

public int matcher(Beann abc)
{
try
{
new OtherClass().insert(abc);
}
catch(Exception e)
{
e.printStackTrace();
}
finally
{
//close the ResultSet ....
//close the Statement ....
//close the Connection ....
}

In Oracle SQL Plus database resource check I see JDBC Thin Client is
opened and not closed after each insert with the above attempt.
This didnt happen when I had the method in the same class.

Please advise.

 

[Patricia Shanahan]

I have a method that inserts data into my Oracle 9i database with no
problems or Database closing issues:

CODE
public class MainClass
{

public PreparedStatement preparer;
public Connection connection;

....

Your inserter method updates preparer to point to the prepared statement.

When you move the insert to OtherClass, does preparer in the MainClass
object still get updated? Does the finally block depend on preparer in
MainClass pointing to the prepared statement?

Patricia

 

[francan00]

...

Your inserter method updates preparer to point to the prepared statement.

When you move the insert to OtherClass, does preparer in the MainClass
object still get updated? Does the finally block depend on preparer in
MainClass pointing to the prepared statement?

Patricia

I assume you are asking if preparer in MainClass updates the database
using the insert from OtherClass. Yes it does update the database but
leaves the database open in some way. If I put the finally block
close statements in OtherClass it wont update the database because it
seems to close the connection/statement before it gets called in
MainClass.