DOM help. setAttribute won't work

fj · May 18, 2005

I have no problem nevigate and neil down the element I want to manipulate.

What I want to do is set the css class of an item according to
window.location (URL). But it doesn't work.

I call this function in
<body onload="SelectMenuItem();" >

here is the function
function SelectMenuItem() {
....
//i is a variable I set before.
var nodes_LI = document.getElementById("TopNav").childNodes;
for (j=0; j<nodes_LI.length; j++) {
nodes_LI[j].firstChild.removeAttribute("class");
}
nodes_LI.firstChild.setAttribute("class", "highlighted");
....
}

DU · May 18, 2005

fj said:
I have no problem nevigate and neil down the element I want to manipulate.

What I want to do is set the css class of an item according to
window.location (URL). But it doesn't work.

I call this function in
<body onload="SelectMenuItem();" >

here is the function
function SelectMenuItem() {
...
//i is a variable I set before.
var nodes_LI = document.getElementById("TopNav").childNodes;
for (j=0; j<nodes_LI.length; j++) {
nodes_LI[j].firstChild.removeAttribute("class");

It seems to me that you're trying to remove the attribute class
specification. You are not trying to remove the attribute node value.

}
nodes_LI.firstChild.setAttribute("class", "highlighted");

Why not then just use DOM 2 HTML method to do this?

if(nodes_LI.firstChild.nodeType == 1)
{
nodes_LI.firstChild.className ="highlighted";
//http://www.w3.org/TR/DOM-Level-2-HTML/html.html#ID-95362176
}
else
{
// code here
};

It's kinda difficult to offer you alternatives or guess better ones
since you have not provided any url nor a complete description of what
you were trying to do exactly.

DU

fj · May 19, 2005

DU said:
fj said:

I have no problem nevigate and neil down the element I want to manipulate.

What I want to do is set the css class of an item according to
window.location (URL). But it doesn't work.

I call this function in
<body onload="SelectMenuItem();" >

here is the function
function SelectMenuItem() {
...
//i is a variable I set before.
var nodes_LI = document.getElementById("TopNav").childNodes;
for (j=0; j<nodes_LI.length; j++) {
nodes_LI[j].firstChild.removeAttribute("class");

Click to expand...

It seems to me that you're trying to remove the attribute class
specification. You are not trying to remove the attribute node value.

}
nodes_LI.firstChild.setAttribute("class", "highlighted");

Click to expand...

Why not then just use DOM 2 HTML method to do this?

if(nodes_LI.firstChild.nodeType == 1)
{
nodes_LI.firstChild.className ="highlighted";
//http://www.w3.org/TR/DOM-Level-2-HTML/html.html#ID-95362176
}
else
{
// code here
};

It's kinda difficult to offer you alternatives or guess better ones
since you have not provided any url nor a complete description of what
you were trying to do exactly.

DU

Thank you. It's works fine now.

I was trying to set the current menu high-lighted by change it's css
class.Now I know I should use .className instead of .attribute.

Doesn't class="myCSSClass" look like an attribute of an element?

-fj

Help with my responsive home page	2	Dec 14, 2022
Help with code	0	Jun 12, 2022
Survey details won't go through using php, ajax, Mysql	0	Oct 26, 2023
All CRUD operations work except POST. Why?	2	May 28, 2023
When draggable=false & draggable=true dont work ?	1	Jan 14, 2023
Need help with stripe payment	0	Oct 2, 2021
Need Help, Both submit button works same, i need both submit button works differently, the one button override other button	3	Nov 9, 2022
Help me sort out this script	1	Oct 17, 2023

DOM help. setAttribute won't work

fj

DU

fj

Ask a Question

Similar Threads

Members online

Forum statistics

Latest Threads