efficient approach to reverse a std::string object

[July]

Hello all

Recentlly, I was asked to write a program in which there is a function
that need to reverse a std::string object.
I wrote like this:
string ReverseString(const string& srcStr)
{
string str;
for(size_t i = 0; i < srcStr.length(); ++i)
str += srcStr[srcStr.length() - i - 1];

return str;
}

Is there any potential error in the ReverseString function?
And if there is any more efficient approach to do this?

 

[benben]

Hello all

Recentlly, I was asked to write a program in which there is a function
that need to reverse a std::string object.
I wrote like this:
string ReverseString(const string& srcStr)
{
string str;
for(size_t i = 0; i < srcStr.length(); ++i)
str += srcStr[srcStr.length() - i - 1];

return str;
}

Is there any potential error in the ReverseString function?

That you can debug...

And if there is any more efficient approach to do this?

std::reverse does exactly that.

 

[msalters]

July schreef:

Hello all

Recentlly, I was asked to write a program in which there is a function
that need to reverse a std::string object.
I wrote like this:
string ReverseString(const string& srcStr)
{
string str;
for(size_t i = 0; i < srcStr.length(); ++i)
str += srcStr[srcStr.length() - i - 1];

return str;
}

Is there any potential error in the ReverseString function?

Seems Ok.

And if there is any more efficient approach to do this?

Reverse iterators:

string ReverseString(const string& srcStr) {
return string( srcStr.rbegin(), srcStr.rend() );
}

You might not even need the function, if you see how simple it
really is.

HTH,
Michiel Salters.