friend ceclaration/definition - is this valid?

[rn]

the code below compiles OK with gcc 4.0 but not with gcc.4.2 and visual
studio 2005 (ver 8 ).

to me it seems it should not compile.

-----

class test1
{
public:

friend test1* newtest1(int x)
{
test1* anobj = new test1();
anobj->finishinit(x);
return anobj;
}

virtual ~test1()
{
}

private:

int avalue;

test1()
{
avalue = 0;
}

void finishinit(int x)
{
avalue = x;
}
};

int main(int argc, char *argv[])
{
test1* tobj = newtest1(5);
delete tobj;

}

 

[alasham.said]

Hello,

Why should it not compile? I happened to notice that same question was
answered and reference to standards given in:
http://lists.apple.com/archives/cocoa-dev/2008/Aug/msg00669.html

Regards.

 

[James Kanze]

the code below compiles OK with gcc 4.0 but not with gcc.4.2
and visual studio 2005 (ver 8 ).

to me it seems it should not compile.

So what are you complaining about? g++ 4.0 had a bug, which has
been corrected, and everything is fine.

More likely, however, you meant that it should compile.

friend test1* newtest1(int x)

Note that this declaration doesn't make the name of the function
visible anywhere but in test1. In pre-standard C++, the name of
a friend function was "injected" into the surrounding namespace
scope (actually into file scope, because in pre-standard C++,
there weren't namespaces). The standard changed this, for a
reason I forget (it's been explained to me several times, but
I've forgotten it as many times); according to the standard,
this name can only be found 1) in newtest1, or 2) using ADL
(except that since it only takes an int as an argument, ADL
can't ever find it, since there are no associated namespaces).

You'll need some declaration in global namespace if you want to
use the function outside of test1.

{
test1* anobj = new test1();
anobj->finishinit(x);
return anobj;
}

virtual ~test1()
{
}

int avalue;

test1()
{
avalue = 0;
}

void finishinit(int x)
{
avalue = x;
}
};

int main(int argc, char *argv[])
{
test1* tobj = newtest1(5);

Here, you're not in the class test1, and there's no declaration
of newtest1 that is visible. So the code shouldn't compile.

 

[rn]

"James Kanze" <[email protected]> skrev i meddelandet

the code below compiles OK with gcc 4.0 but not with gcc.4.2
and visual studio 2005 (ver 8 ).

to me it seems it should not compile.

So what are you complaining about?

I'm not complaining, I was asking a question

g++ 4.0 had a bug, which has
been corrected, and everything is fine.

exactly and that's what I'm trying to confirm

More likely, however, you meant that it should compile.

No, I meant that it should not compile which it does on gcc 4.0
but not on gcc 4.2 and Visual Studio

So the code is wrong which I wanted to confirm

friend test1* newtest1(int x)

Note that this declaration doesn't make the name of the function
visible anywhere but in test1. In pre-standard C++, the name of
a friend function was "injected" into the surrounding namespace
scope (actually into file scope, because in pre-standard C++,
there weren't namespaces). The standard changed this, for a
reason I forget (it's been explained to me several times, but
I've forgotten it as many times); according to the standard,
this name can only be found 1) in newtest1, or 2) using ADL
(except that since it only takes an int as an argument, ADL
can't ever find it, since there are no associated namespaces).

You'll need some declaration in global namespace if you want to
use the function outside of test1.

{
test1* anobj = new test1();
anobj->finishinit(x);
return anobj;
}

virtual ~test1()
{
}

int avalue;

test1()
{
avalue = 0;
}

void finishinit(int x)
{
avalue = x;
}
};

int main(int argc, char *argv[])
{
test1* tobj = newtest1(5);

Here, you're not in the class test1, and there's no declaration
of newtest1 that is visible. So the code shouldn't compile.