getelementbyid problem

Michael Winter · Apr 16, 2005

On 17/04/2005 23:26, Warren Thai wrote:

[snip]

[T]he line ----
document.getElementById('id').firstChild.data = 'CORRECT';
---- doesn't work with the ('id') part.

If course not. There is no element with the id, 'id'. Remove the
quotes so that the sequence is evaluated as an identifier and a
property accessor, not a string literal.

[snip]

<HEAD>
<SCRIPT language = 'Javascript'>

Click to expand...

The language attribute is deprecated. Use the (required) type
attribute instead:

<script type="text/javascript">

You also seem to have omitted the required TITLE element.

var ans = new Array('0','0');

Click to expand...

It tends to be better to use array literals, rather than Array
constructors:

var ans = ['0', '0'];

[snip]

<a id=id[0]> </a>

Click to expand...

Out of interest, why are you writing into A elements? Wouldn't P or
SPAN elements be more appropriate? Secondly, square brackets are not
allowed as part of id attribute values. If you really want a
separator, you could use a hyphen (-), underscore (_), colon ), or
dot (.).

[snip]

Mike

Warren Thai · Apr 17, 2005

I am writing a webpage to display a small quiz, below is the code of the
webpage. I used a for loop so that if there are a lot of questions, it would
reduce the code. but the line ----
document.getElementById('id').firstChild.data = 'CORRECT'; ---- doesn't
work with the ('id') part. if i use ('id[0]') it works. the ans works
too. is it something to do with calling the id from an array. how can i
solve this problem and keeping the for loop.

<HTML>
<HEAD>
<SCRIPT language = 'Javascript'>
var ans = new Array('0','0');
var correctans = new Array('4','2');
var correctansstring = new Array('4','6');
var id = new Array('id1','id2');

function check()
{
for(i = 0; i < 2; i++)
{
if(ans == correctans)
{
document.getElementById('id').firstChild.data = 'CORRECT';
document.getElementById('id').style.color = 'green';
}
else
{
document.getElementById('id').firstChild.data = 'WRONG\nThe correct
answer is: '+correctansstring;
document.getElementById('id').style.color = 'red';
}
}
}
</SCRIPT>
</HEAD>
<BODY>
1. What is 2 + 2?<BR>
<INPUT type = 'radio' name = 'q1' onClick = 'ans[0] = 1'> 1<BR>
<INPUT type = 'radio' name = 'q1' onClick = 'ans[0] = 2'> 2<BR>
<INPUT type = 'radio' name = 'q1' onClick = 'ans[0] = 3'> 3<BR>
<INPUT type = 'radio' name = 'q1' onClick = 'ans[0] = 4'> 4<BR>
<a id=id[0]> </a>
<BR>
1. What is 3 + 3?<BR>
<INPUT type = 'radio' name = 'q2' onClick = 'ans[1] = 1'> 5<BR>
<INPUT type = 'radio' name = 'q2' onClick = 'ans[1] = 2'> 6<BR>
<INPUT type = 'radio' name = 'q2' onClick = 'ans[1] = 3'> 7<BR>
<INPUT type = 'radio' name = 'q2' onClick = 'ans[1] = 4'> 8<BR>
<a id=id[0]> </a>
<BR>
<INPUT type = 'button' value = 'CHECK' onClick = 'check()'><BR>
</BODY>
</HTML>

Incrementing getelementbyid	1	Jan 6, 2022
Wanting to use getElementById()	17	Dec 9, 2011
getElementById returns null	6	Jan 25, 2009
In javascript, XML File Create, File Save	2	Jul 17, 2023
getElementById in MSIE	4	Aug 9, 2008
Timing problem	4	May 1, 2023
problem with getElementById under IE 7	7	Feb 14, 2008
IE 7, getElementById, iframe	0	Aug 30, 2007

getelementbyid problem

Michael Winter

Warren Thai

Ask a Question

Similar Threads

Members online

Forum statistics

Latest Threads