Global variable does not want to change...

jimmy.dillies · Nov 8, 2006

Hello, I have a global variable which does not want to change :
<header>
....
<script type="text/javascript" language="JavaScript">
var i=1;
function swap()
{
var window.i = 1 - window.i ;
}
.....
</script>
....
<body>

<A href="" ... onclick="swap()"> <img src="pix/star.gif" > </A>

when clicking on 'star.gif', i does not change from 1 to 0 ...

Any clue ?
Thanks,
Jimmy

buhailiang · Nov 8, 2006

"(e-mail address removed) Ð´µÀ£º
"

Hello, I have a global variable which does not want to change :
<header>
...
<script type="text/javascript" language="JavaScript">
var i=1;
function swap()
{
var window.i = 1 - window.i ;

~~~you reclaim the value, delete the "var" will be ok

Lich_Ray · Nov 8, 2006

Using global variable is not a good choose. Remenber global function is
always blind to global namespace. The best choose is, use "this.i"
instead of "window.i".

Lee · Nov 8, 2006

Lich_Ray said:

Using global variable is not a good choose. Remenber global function is
always blind to global namespace. The best choose is, use "this.i"
instead of "window.i".

If I understand you correctly, you're wrong.
functions have full access to global variables.
That's what "global" means:

<html>
<body>
<script type="text/javascript">
var globalVariable="Hello, world!";
function globalFunction() {
alert(globalVariable);
globalVariable="Goodbye";
}
globalFunction();
alert(globalVariable);
</script>
</body>
</html>

--

Michael Winter · Nov 8, 2006

(e-mail address removed) wrote:

[snip]

<script type="text/javascript" language="JavaScript">

The language attribute is deprecated and redundant. Omit it.

var i=1;
function swap()
{
var window.i = 1 - window.i ;

That is a syntax error: variable declarations consist of a comma
separated list of /identifiers/, with optional initialisers. The
character sequence, "window.i" is not an identifier.

function swap() {
i = 1 - i;
}

will do. You don't want a variable declaration within the function body:
that would make i a local variable.

[snip]

Mike

Why is Python telling me variable is local not global?	3	Sep 2, 2023
I want to Display Excel As HTML In js	2	Feb 24, 2023
How to treat an input data as variable?	4	Apr 13, 2023
Global Variable staying undefined with Ajax Response	2	Mar 19, 2022
Angularjs newbie - second JSON datasource does not display	0	May 18, 2022
Uncaught ReferenceError: item is not defined at HTMLButtonElement.onclick in the: <button onclick="item.inserir()">Inserir dados</button>	1	Apr 22, 2023
How to change star rating color on mouseenter, on mouseout, and on onclick	0	Sep 28, 2018
How to change the color in this script	1	Sep 9, 2022

Global variable does not want to change...

jimmy.dillies

buhailiang

Lich_Ray

Lee

Michael Winter

Ask a Question

Similar Threads

Members online

Forum statistics

Latest Threads