Help me find my lost code!

K

Kayda

Hello:

I had some code that allowed me to expand a paragraph by clicking on a
hyperlink and collapse it by clicking on the paragraph. I unfortunately the
Javascript function. I still have the code that calls it

Here is how the calling paragraph looks:

<div id="menu7"><A HREF="" onclick="return ExpandHideContent('menu1','i7',
'c7')">Hyperlink that displays when page first viewed</A></div>
<div id="i7"><BR>
<A HREF="" onclick="return ExpandHideContent('menu1','i7', 'c7')"><IMG
SRC="CollapseBelowContent.gif" BORDER=0></A>

<P>CONTENT</P>

<A HREF="" onclick="return ExpandHideContent('menu1','i7', 'c7')"><IMG
SRC="graphics/CollapseAboveContent.gif" BORDER=0></A><BR>
</div>

There are a series of sections like this, so when you open the page you just
see a list of hyperlinks. You click on the hyperlink, it shows everything in
the code below (plus all the original hyperlinks stay there, i.e.:

Hyperlink1
Hyperlink2
Hyperlink3

click on hyperlink1 and you get:
Hyperlink1
Content
Hyperlink2
Hyperlink3


You click on the content or the .gifs and the content disappears..

The "ExpandHideContent" function was pretty simple, but I can't remember
what it was, and I'm feeling too busy to figure it out. The gifs basically
are funky text that say what the filenames imply.

Can someone help?

Blair
 
K

Kayda

Actually, I found my code with a Google Groups search. The code is below,
but when I click on the hyperlink it briefly shows the content and then
sends me to the site's homepage. Any ideas?

<SCRIPT LANGUAGE="JavaScript">


var counter1 = 0;
var counter2 = 0;
var counter3 = 0;
var counter4 = 0;
var counter5 = 0;
var counter6 = 0;
var counter7 = 0;

function ExpandHideContent(the_id, the_iframe, the_counter)
{
if (the_counter == "c1") { ++counter1; }
if (the_counter == "c2") { ++counter2; }
if (the_counter == "c3") { ++counter3; }
if (the_counter == "c4") { ++counter4; }
if (the_counter == "c5") { ++counter5; }
if (the_counter == "c6") { ++counter6; }
if (the_counter == "c7") { ++counter7; }

ifrm = document.getElementById(the_iframe);

if (counter1 == 1)
{
counter1++;
ifrm.style.display = "block";
return;
}
if (counter2 == 1)
{
counter2++;
ifrm.style.display = "block";
return;
}
if (counter3 == 1)
{
counter3++;
ifrm.style.display = "block";
return;
}

if (counter4 == 1)
{
counter4++;
ifrm.style.display = "block";
return;
}
if (counter5 == 1)
{
counter5++;
ifrm.style.display = "block";
return;
}
if (counter6 == 1)
{
counter6++;
ifrm.style.display = "block";
return;
}

if (counter7 == 1)
{
counter7++;
ifrm.style.display = "block";
return;
}


if (ifrm.style.display == "none")
{
//alert(ifrm.style.display);
ifrm.style.display = "block";
}
else
{
//alert(ifrm.style.display);
ifrm.style.display = "none";
}

}
</SCRIPT>
 
I

Ivo

Kayda said:
but when I click on the hyperlink it briefly shows the content and then
sends me to the site's homepage. Any ideas?

<SCRIPT LANGUAGE="JavaScript">

The language attribute should not be used. Use type="text/javascript"
instead. This is required for validation, but won't solve the problem.

function ExpandHideContent(the_id, the_iframe, the_counter)
ifrm = document.getElementById(the_iframe);

if (counter1 == 1)
{
counter1++;
ifrm.style.display = "block";
return;

Change this line (and the other lines in the function) to:
return FALSE; // capitalization is optional


and follows the href when clicked. The called function should return false
in order to prevent the href from being followed. Currently it returns, but
not false.
HTH
Ivo
 
I

Ivo

Kayda said:
but when I click on the hyperlink it briefly shows the content and then
sends me to the site's homepage. Any ideas?

<SCRIPT LANGUAGE="JavaScript">

The language attribute should not be used. Use type="text/javascript"
instead. This is required for validation, but won't solve the problem.

function ExpandHideContent(the_id, the_iframe, the_counter)
ifrm = document.getElementById(the_iframe);

if (counter1 == 1)
{
counter1++;
ifrm.style.display = "block";
return;

Change this line (and the other lines in the function) to:
return FALSE; // capitalization is optional


and follows the href when clicked. The called function should return false
in order to prevent the href from being followed. Currently it returns, but
not false.
HTH
Ivo
 
I

Ivo

Kayda said:
but when I click on the hyperlink it briefly shows the content and then
sends me to the site's homepage. Any ideas?

<SCRIPT LANGUAGE="JavaScript">

The language attribute should not be used. Use type="text/javascript"
instead. This is required for validation, but won't solve the problem.

function ExpandHideContent(the_id, the_iframe, the_counter)
ifrm = document.getElementById(the_iframe);

if (counter1 == 1)
{
counter1++;
ifrm.style.display = "block";
return;

Change this line (and the other lines in the function) to:
return FALSE; // capitalization is optional


and follows the href when clicked. The called function should return false
in order to prevent the href from being followed. Currently it returns, but
not false.
HTH
Ivo
 
K

Kayda

That made perfect sense, but it seems it is still going to the homepage when
I click on the links. You see the content for a split second, but then
returns to the homepage.

Did you mean to change something in the calling hyperlink, or just put the
"return FALSE" in the code?

Thanks,
Blair
 
M

Michael Winter

[snip]
Change this line (and the other lines in the function) to:
return FALSE; // capitalization is optional

No it's not; the case of the false keyword is, and can only be, lowercase.
If any of the characters are uppercase, the JavaScript interpreter will
try to find a variable of that name and capitalisation.

[snip]

Mike
 
L

Lasse Reichstein Nielsen

Ivo said:
return FALSE; // capitalization is optional

Nope, Javascript is case sensitive. "FALSE" is an unknown variable,
while "false" is syntax for a boolean value.

/L
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Similar Threads


Members online

Forum statistics

Threads
473,769
Messages
2,569,580
Members
45,055
Latest member
SlimSparkKetoACVReview

Latest Threads

Top