Help with random script...

F

Franklin P Patchey

I have modified some script and think i have put a bit in that isn't
"compliant"
Is the bit marked below (towards the end) correct - should it be () and not
("")

<SCRIPT LANGUAGE="JavaScript">
<!-- hiding
page=new Date();
if (page.getDate() == 1)
document.write("<embed src='media/audio/waltzinblack.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 2)
document.write("<embed src='media/audio/littlegreenbag.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 3)
document.write("<embed src='media/audio/rockthecasbah.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 4)
document.write("<embed src='media/audio/softparade.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 5)
document.write("<embed src='media/audio/cematinla.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 6)
document.write("<embed src='media/audio/venusinfurs.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 7)
document.write("<embed src='media/audio/allineed.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 8)
document.write("<embed src='media/audio/heroin.mp3' width='145' height='60'
autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 9)
document.write("<embed src='media/audio/grooveme.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 10)
document.write("<embed src='media/audio/totu.mp3' width='145' height='60'
autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 11)
document.write("<embed src='media/audio/monstermash.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 12)
document.write("<embed src='media/audio/twilightzone.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 13)
document.write("<embed src='media/audio/sundaygirl.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 14)
document.write("<embed src='media/audio/theuniversal.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 15)
document.write("<embed src='media/audio/closetome.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 16)
document.write("<embed src='media/audio/kungfufighting.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 17)
document.write("<embed src='media/audio/youandmesong.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 18)
document.write("<embed src='media/audio/totu.mp3' width='145' height='60'
autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 19)
document.write("<embed src='media/audio/americanbeauty.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 20)
document.write("<embed src='media/audio/closetome.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 21)
document.write("<embed src='media/audio/hourformagic.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 22)
document.write("<embed src='media/audio/theuniversal.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 23)
document.write("<embed src='media/audio/themovie.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 24)
document.write("<embed src='media/audio/blackpolishedchrome.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 25)
document.write("<embed src='media/audio/stonedimmaculate.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 26)
document.write("<embed src='media/audio/rockthecasbah.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 27)
document.write("<embed src='media/audio/waltzinblack.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 28)
document.write("<embed src='media/audio/sundaygirl.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 29)
document.write("<embed src='media/audio/allineed.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 30)
document.write("<embed src='media/audio/youandmesong.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");

if (page.getDate() == 31)
document.write("<embed src='media/audio/twilightzone.mp3' width='145'
height='60' autostart='true' hidden='true' loop='false' volume='70'>");
page=new Date();

document.write("") -------------THIS BIT HERE!!!
//done hiding -->
</SCRIPT>
 
F

Fabian

Franklin P Patchey hu kiteb:
I have modified some script and think i have put a bit in that isn't
"compliant"
Is the bit marked below (towards the end) correct - should it be ()
and not ("") ....
document.write("") -------------THIS BIT HERE!!!

Isn't the intended functionality equivalent to having nothing at all for
that line of code? If you want a carriage return written, use \n as an
escape character. I can't imagine any instance in which a write
statement makes sense with a null value.
 
L

Lee

Franklin P Patchey said:
I have modified some script and think i have put a bit in that isn't
"compliant"
Is the bit marked below (towards the end) correct - should it be () and not
("")
...
page=new Date();

document.write("") -------------THIS BIT HERE!!!
//done hiding -->
</SCRIPT>

That line doesn't do anything, anyway. Take it out.
The line just before it [page=new Date()] doesn't serve any
purpose, either.
 
L

Lee

Fabian said:
Franklin P Patchey hu kiteb:


Isn't the intended functionality equivalent to having nothing at all for
that line of code? If you want a carriage return written, use \n as an
escape character. I can't imagine any instance in which a write
statement makes sense with a null value.

A carriage return would still be nearly equivalent to nothing at all,
since it displays in HTML as a single white-space character.

To get a line break, use:

document.write("<br>");
 
D

Dr John Stockton

JRS: In article <[email protected]>, seen in
news:comp.lang.javascript said:
Fabian said:

If one wants a CR, CRLF, or newline written, one uses
document.writeln().

An empty string is not a null value.

Writing a literal empty string is pointless as such; but it might occur
as a result of automated code generation.

A carriage return would still be nearly equivalent to nothing at all,
since it displays in HTML as a single white-space character.

To get a line break, use:

document.write("<br>");

Not necessarily in general, it might be in <pre>; although not in this
case.


More importantly, there seems to be 31 statements identical except for
the file name; the lot should be replaceable by a single statement

document.write("<embed src='media/audio/", FileName[page.getDate()] ,
".mp3' width='145' height='60' autostart='true' hidden='true'",
" loop='false' volume='70'>");

after

FileName = ["", "waltzinblack", ..., "twilightzone"]
 
F

Franklin P Patchey

I like Dr John's idea on the short version of what I have copied (I don't
understand javascript really, so please treat me as thick!)

where do I insert the filenames of my mp3's so the script knows what to
play?
 
F

Fabian

Franklin P Patchey hu kiteb:
I like Dr John's idea on the short version of what I have copied (I
don't understand javascript really, so please treat me as thick!)

where do I insert the filenames of my mp3's so the script knows what
to play?
---------
What goes at the beginning here too?
document.write("<embed src='media/audio/", FileName[page.getDate()] ,
".mp3' width='145' height='60' autostart='true' hidden='true'",
" loop='false' volume='70'>");

Wouldnt a better idea be to have the javascript write a link to the file
instead? That way, the user can choose how much bandwidth your site will
consume. The smallest mp3 of listenable quality I have seen is about
half a meg. That is non-trivial on anything less than a cable
connection.
 
D

Dr John Stockton

JRS: In article <[email protected]>, seen in
Franklin P Patchey
I like Dr John's idea on the short version of what I have copied (I don't
understand javascript really, so please treat me as thick!)

where do I insert the filenames of my mp3's so the script knows what to
play?

You're posting via pol.co.uk, so you should understand English. Read
all that I wrote, considering the exact meanings of all of the words.
 
F

Fabian

Dr John Stockton hu kiteb:
You're posting via pol.co.uk, so you should understand English. Read
all that I wrote, considering the exact meanings of all of the words.

And I'm posting from a German news server, so I suppose that means I
should understand German?

Or perhaps if I used my ISP's extraordinarily flaky Japan-based server,
would that make me fluent in Japanese?
 
F

Franklin P Patchey

Nice one Fabian!
I have noticed that a lot of people in this newsgroup (and others) attempt
to be helpful, but at the same time intensely condescending and short
sighted. A typical computer obsessive (John Stockton).
No I don't understand and don't mind admitting it. I pay you a compliment
that your shortened script is better and you reply with rudeness - what's
going on there?

Just because I understand English doesn't mean I will understand a computer
code that I have no idea about. I lifted the original script from
Bravenet.com on their help pages. I don't know how to modify it so it is
shorter but still works and you shouldn't assume that just because I
understand English and am posting in a PC newsgroup that I understand
everything about computers including Javascript.

I don't want you opinions, just help with the script. If you are going to
give it then thank you, if not then just don't reply at all - be a rational,
reasonable adult!
 
F

Fabian

Franklin P Patchey hu kiteb:
Nice one Fabian!
... I pay you a
compliment that your shortened script is better and you reply with
rudeness - what's going on there?

I'm confused. I don't recall seeing any replies from you on the matter
of my shortened script. And I don't recall writing a rude response to
you. I would be pleased if you would highlight what exactly I wrote to
you that you consider so rude.
 
F

Franklin P Patchey

No you didn't. I am referring to Dr John Stockton saying that as I'm posting
from a UK server that I should understand English. You weren't rude the Dr
guy
 
D

Dr John Stockton

JRS: In article <[email protected]>, seen in
Franklin P Patchey
No you didn't. I am referring to Dr John Stockton saying that as I'm posting
from a UK server that I should understand English.

You wrote "(I don't understand javascript really, so please treat me as
thick!)". I saw no reason to disagree with the first part, so I
complied with the second part.

You should read the newsgroup FAQ with care, to find out (/inter alia/)
how news posts and replies should be formatted; it will increase your
chances of getting useful replies in future.
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Members online

No members online now.

Forum statistics

Threads
473,770
Messages
2,569,583
Members
45,074
Latest member
StanleyFra

Latest Threads

Top