How to simplify "a.instance_of? classX or a.instance_of? classY "

[Stephane Wirtel]

Hi all,

I would like to know if there is a way to simplify this code

object.instance_of? WSDL::XMLSchema::ComplexContent or
object.instance_of? WSDL::XMLSchema::ComplexType or
object.instance_of? WSDL::XMLSchema::SimpleType or
object.instance_of? WSDL::XMLSchema::SimpleRestriction or
object.instance_of? WSDL::XMLSchema::Element or
object.instance_of? WSDL::XMLSchema::Sequence or
object.instance_of? XSD::QName or
object.instance_of? WSDL::Message or
object.instance_of? WSDL:art or
object.instance_of? WSDL::Service or
object.instance_of? WSDL:ort or
object.instance_of? WSDL::SOAP::Address or
object.instance_of? WSDL::Binding or
object.instance_of? WSDL::SOAP::Binding or
object.instance_of? WSDL::OperationBinding or
object.instance_of? WSDL::SOAP::Operation or
object.instance_of? WSDL:aram or
object.instance_of? WSDL::SOAP::Body or
object.instance_of? WSDL:ortType or
object.instance_of? WSDL::Operation or
object.instance_of? WSDL::SOAP::Attribute

?

Thanks

 

[Ezra Zygmuntowicz]

Hi all,

I would like to know if there is a way to simplify this code

object.instance_of? WSDL::XMLSchema::ComplexContent or
object.instance_of? WSDL::XMLSchema::ComplexType or
object.instance_of? WSDL::XMLSchema::SimpleType or
object.instance_of? WSDL::XMLSchema::SimpleRestriction or
object.instance_of? WSDL::XMLSchema::Element or
object.instance_of? WSDL::XMLSchema::Sequence or
object.instance_of? XSD::QName or
object.instance_of? WSDL::Message or
object.instance_of? WSDL:art or
object.instance_of? WSDL::Service or
object.instance_of? WSDL:ort or
object.instance_of? WSDL::SOAP::Address or
object.instance_of? WSDL::Binding or
object.instance_of? WSDL::SOAP::Binding or
object.instance_of? WSDL::OperationBinding or
object.instance_of? WSDL::SOAP::Operation or
object.instance_of? WSDL:aram or
object.instance_of? WSDL::SOAP::Body or
object.instance_of? WSDL:ortType or
object.instance_of? WSDL::Operation or
object.instance_of? WSDL::SOAP::Attribute

?

Thanks

[
WSDL::XMLSchema::ComplexContent,
WSDL::XMLSchema::ComplexType,
WSDL::XMLSchema::SimpleType,
WSDL::XMLSchema::SimpleRestriction,
WSDL::XMLSchema::Element,
WSDL::XMLSchema::Sequence,
XSD::QName,
WSDL::Message,
WSDL:art,
WSDL::Service,
WSDL:ort,
WSDL::SOAP::Address,
WSDL::Binding,
WSDL::SOAP::Binding,
WSDL::OperationBinding,
WSDL::SOAP::Operation,
WSDL:aram,
WSDL::SOAP::Body,
WSDL:ortType,
WSDL::Operation,
WSDL::SOAP::Attribute
].any? {|cls| object.instance_of? cls}


Thats one way to skin this cat. But I have to call code smell on
this whole check to see if this object is an instance of all these
classes. Maybe there is an easier way to accomplish what you want if
you expound on the question?

Cheers-
-- Ezra Zygmuntowicz
-- Lead Rails Evangelist
-- (e-mail address removed)
-- Engine Yard, Serious Rails Hosting
-- (866) 518-YARD (9273)

 

[Phrogz]

I would like to know if there is a way to simplify this code

object.instance_of? WSDL::XMLSchema::ComplexContent or
object.instance_of? WSDL::XMLSchema::ComplexType or
object.instance_of? WSDL::XMLSchema::SimpleType or

[snip]

case object
when WSDL::XMLSchema::ComplexContent, WSDL::XMLSchema::ComplexType,
WSDL::XMLSchema::SimpleType
# your code here
end

For example:

irb(main):001:0> class Foo; end; class Bar; end; class Jimmy; end
=> nil
irb(main):002:0> o = Bar.new
=> #<Bar:0x356f74>
irb(main):003:0> case o; when Foo, Bar; p "yay"; else; p "boo"; end
"yay"
=> nil
irb(main):004:0> o = Jimmy.new
=> #<Jimmy:0x34416c>
irb(main):005:0> case o; when Foo, Bar; p "yay"; else; p "boo"; end
"boo"
=> nil

 

[Trans]

If any are subclasses of the other's then use only the superclass.

T.

 

[F. Senault]

Le 4 novembre 2006 à 04:57, Phrogz a écrit :

I would like to know if there is a way to simplify this code

object.instance_of? WSDL::XMLSchema::ComplexContent or
object.instance_of? WSDL::XMLSchema::ComplexType or
object.instance_of? WSDL::XMLSchema::SimpleType or

[snip]

case object
when WSDL::XMLSchema::ComplexContent, WSDL::XMLSchema::ComplexType,
WSDL::XMLSchema::SimpleType
# your code here
end

Maybe more legible (and allows you to reuse the test) :

LIST = [ WSDL::XMLSchema::ComplexContent,
WSDL::XMLSchema::ComplexType,
WSDL::XMLSchema::SimpleType,
...
]
....

case object
when *LIST
...
end

Fred

 

[Phrogz]

Maybe more legible (and allows you to reuse the test) :

LIST = [ WSDL::XMLSchema::ComplexContent,
WSDL::XMLSchema::ComplexType,
WSDL::XMLSchema::SimpleType,
...
]
...

case object
when *LIST
...
end

Fred

Very nice.