Problem posting form to an IFrame

T

Tom Cole

I have a rather complicated business application that uses Ajax. Part
of this form requires uploading documents, which I cannot do using
Ajax, so I post the form to an IFrame. This part works just fine.

The problem I have is that my server process returns some content to
the IFrame to complete form processing and to report any errors that
might have occured. Here's an example of what may be written back:

<html>
<head>
<script type="text/javascript">
function completed() {
window.parent.reportsCompleted();
}
</script>
<body onload="completed();">
<error>The document type .doc is not supported.</error>
</body>
</html>

Now this does properly call the reportsCompleted method of the parent
frame. The problem I am having is reading the contents of any <error>
tags if they exist:

function reportsCompleted() {
var frame = frames['upload_frame'];
if (frame.document.getElementsByTagName("error").length > 0) { //
there were errors...
var message = "The following error(s) occured:";
for (var i = 0; i <
frame.document.getElementsByTagName("error").length; i++) {
message += "\n" +
frame.document.getElementsByTagName("error").nodeValue();
}
alert(message);
}
}

The problem is that I never get the contents of the error tags
displayed. I only see an alert window that says "The following
error(s) occured:".

What am I doing wrong?
 
R

RoLo

I have a rather complicated business application that uses Ajax. Part
of this form requires uploading documents, which I cannot do using
Ajax, so I post the form to an IFrame. This part works just fine.

The problem I have is that my server process returns some content to
the IFrame to complete form processing and to report any errors that
might have occured. Here's an example of what may be written back:

<html>
<head>
<script type="text/javascript">
function completed() {
    window.parent.reportsCompleted();}

</script>
<body onload="completed();">
<error>The document type .doc is not supported.</error>
</body>
</html>

Now this does properly call the reportsCompleted method of the parent
frame. The problem I am having is reading the contents of any <error>
tags if they exist:

function reportsCompleted() {
    var frame = frames['upload_frame'];
    if (frame.document.getElementsByTagName("error").length > 0) { //
there were errors...
        var message = "The following error(s) occured:";
        for (var i = 0; i <
frame.document.getElementsByTagName("error").length; i++) {
            message += "\n" +
frame.document.getElementsByTagName("error").nodeValue();
        }
        alert(message);
    }

}

The problem is that I never get the contents of the error tags
displayed. I only see an alert window that says "The following
error(s) occured:".

What am I doing wrong?
Click to expand...


why not use .innerHTML instead of your non existent .nodeValue()?
http://developer.mozilla.org/en/docs/DOM:element.nodeValue
 
T

Thomas 'PointedEars' Lahn

Tom said:
[...]
The problem I have is that my server process returns some content to
the IFrame to complete form processing and to report any errors that
might have occured. Here's an example of what may be written back:

<html>
<head>
<script type="text/javascript">
function completed() {
window.parent.reportsCompleted();
}
</script>
<body onload="completed();">
<error>The document type .doc is not supported.</error>
</body>
</html>

[...] The problem I am having is reading the contents of any <error>
tags if they exist:

function reportsCompleted() {
var frame = frames['upload_frame'];
if (frame.document.getElementsByTagName("error").length > 0) { //
there were errors...
Click to expand...

Use instead:

if (frame)
{
// add feature test here
var c = frame.document.getElementsByTagName("error");

var len = c.length;

if (len > 0)
{
var message = "The following error(s) occured:";
for (var i = 0; i <
.length; i++) {
Click to expand...

var message = [];

for (var i = 0; i < len; i++)
{
message += "\n" +
frame.document.getElementsByTagName("error").nodeValue();
message.push(c.nodeValue;
}
alert(message);
Click to expand...

}

window.alert(message.join("\n"));
}
}
Click to expand...

}

The problem is that I never get the contents of the error tags
displayed. I only see an alert window that says "The following
error(s) occured:".

What am I doing wrong?
Click to expand...


Using non-HTML elements in a supposed-to-be HTML document,
and calling a property although it is not a method.

http://jibbering.com/faq/#FAQ4_43
http://validator.w3.org/


PointedEars
 
G

gunnrosebutpeace

the <error> is not standard HTML elements then different browsers have
diffent behavior on unknow tag

for IE, you should define a namespace for custom elements
(xmlns:my="http://xxxx....", then use my:error, then use
document.getELementsByTagName("error"))
for Firefox, you need not to define namespace, but you have to write
document.getElementsByTagName("my:error");
It'd better to use standard HTML element (p, span) and innerHTML.
 
H

Henry

the <error> is not standard HTML elements then different
browsers have diffent behavior on unknow tag

for IE, you should define a namespace for custom elements
(xmlns:my="http://xxxx....", then use my:error, then use
document.getELementsByTagName("error"))
for Firefox, you need not to define namespace, but you have
to write document.getElementsByTagName("my:error");
It'd better to use standard HTML element (p, span) and
innerHTML.
Click to expand...

Because different browsers have (and should be expected to have)
different behaviour when they encounter an unrecognised element in an
HTML document the specifics of the behaviour of just two of those
browsers is of very little use or relevance.

Because the response that includes the message is being generated it
would be possible to generate it in any form, and the simplest form
would be to take the character sequence that would otherwise appear in
the "error" element and appropriately escape it for inclusion in a
javascript string literal context and insert it as a string literal
argument to the - reportsCompleted - function call:-

// with double quotes and line terminators in the string (at minimum)
// replaces with their equivalent escape sequences.
window.parent.reportsCompleted(
"The document type .doc is not supported"
);

(with either no argument or an empty string as an argument in the
event that there was no error to report.)

Or assign it to a local variable (perhaps called 'error' for example,
but preferably something longer and less likely to coincide with a pre-
existing window property):-

// with double quotes and line terminators in the string (at minimum)
// replaces with their equivalent escape sequences.
var error = "The document type .doc is not supported."

- and have the reportsCompleted - function access it as:-

frames['upload_frame'].error

And in the (apparently likely( event that it is anticipated that there
be more than one error to report the string literals of the errors
could instead appear in an array literal.
 
T

Thomas 'PointedEars' Lahn

Thomas said:
Tom Cole wrote:
[...]
message += "\n" +
frame.document.getElementsByTagName("error").nodeValue();
Click to expand...


message.push(c.nodeValue;
Click to expand...


message.push(c.nodeValue);

and it should work with Valid markup. Sorry.


PointedEars
 
T

Tom Cole

Thomas said:
Tom Cole wrote:
[...]
            message += "\n" +
frame.document.getElementsByTagName("error").nodeValue();
Click to expand...
Click to expand...

        message.push(c.nodeValue;
Click to expand...


        message.push(c.nodeValue);

and it should work with Valid markup.  Sorry.

PointedEars
--
Prototype.js was written by people who don't know javascript for people
who don't know javascript. People who don't know javascript are not
the best source of advice on designing systems that use javascript.
  -- Richard Cornford, cljs, <[email protected]>
Click to expand...


Thank you for you assistance. I should have figured using an unknown
tag would cause unpredictable results. I've changed all the tags to
<span> elements and use the className to denote them as errors or not.
This seems to work just fine.
 
C

Captain Paralytic

I have a rather complicated business application that uses Ajax. Part
of this form requires uploading documents, which I cannot do using
Ajax,
Click to expand...
Why not?
 
T

Thomas 'PointedEars' Lahn

Tom said:
How would you perform a fileupload with Ajax?
Click to expand...

Submit the form to a dynamically generated (hidden) iframe (the dynamical
part is optional), and read back the upload status through an XHR request.
BTDT.


PointedEars
 
T

Tom Cole

Submit the form to a dynamically generated (hidden) iframe (the dynamical
part is optional), and read back the upload status through an XHR request.
BTDT.

PointedEars
--
Anyone who slaps a 'this page is best viewed with Browser X' label on
a Web page appears to be yearning for the bad old days, before the Web,
when you had very little chance of reading a document written on another
computer, another word processor, or another network. -- Tim Berners-Lee
Click to expand...

That's what I am doing, I guess I was incorrect in my previous
statement. I tend to use the terms "Ajax" and "XHR" as synonyms which
I guess they are not.
I guess I meant that I could not process document uploads using XHR.
 
C

Captain Paralytic

How would you perform a fileupload with Ajax?
Click to expand...

Take a look at Google Mail. When you select a file for attaching to an
email, it gets uploaded immediately in the background, whilst you are
still composing the email.
 
T

Tom Cole

Take a look at Google Mail. When you select a file for attaching to an
email, it gets uploaded immediately in the background, whilst you are
still composing the email.
Click to expand...

I've noticed that when I use this form submission to an IFrame
technique, in Internet Explorer there is a little progress bar that
appears in the bottom status bar of rhe browser as if something is
still processing, even after my server send the response and my IFrame
is populated. It doesn't appear to affect anything, but is strange.
Opera, FF, Safari does not exhibit this behaviour.
 
C

Captain Paralytic

I've noticed that when I use this form submission to an IFrame
technique, in Internet Explorer there is a little progress bar that
appears in the bottom status bar of rhe browser as if something is
still processing, even after my server send the response and my IFrame
is populated. It doesn't appear to affect anything, but is strange.
Opera, FF, Safari does not exhibit this behaviour.
Click to expand...

Have you checked GM in IE to see if it does this too?
 
T

Tom Cole

Have you checked GM in IE to see if it does this too?- Hide quoted text -

- Show quoted text -
Click to expand...

It appears to behave the same. And BTW it's in Firefox, not IE that is
does this. As I mentioned everything is working just fine so I'll just
leave it alone for now.
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Similar Threads

Is it possible an iframe can overlapp another? 3
Trying to add text into an editable div that is in an iframe 0
Registration Form 7
Iframe cross-domain access with JavaScript 1
I want to Display Excel As HTML In js 2
How to store data from a sign up form on a website into an sql databse 1
Javascipt problem. 22
posting content to an iframe 2

Members online

No members online now.
Total: 24 (members: 0, guests: 24)
Robots: 358

Forum statistics

Threads
473,769
Messages
2,569,582
Members
45,065
Latest member
OrderGreenAcreCBD

Latest Threads

Top