Problems with XML & JavaScript

A

arun32581

I am developing a page for Mozilla/IE which reads xml data and when the
link on the page is clicked it displays the data as a table.
The display is controlled by a Javascript. Everything works fine. But
in the table one of the sections is a URL. I want this to be clickable
so that it takes me to the corresponding webpage. I am new to this and
tried hard to fix this but cudnt find my way around. I tried adding an
xsl sheet but still it doesnt seem to fix the problem.
Could anyone help me out. I have pasted the code below

Thanks a lot



***XML*****

<?xml version="1.0" encoding="ISO-8859-1"?>
<logs>
<Websites>
<title>Google</title>
<country>US</country>
<URL>http://www.google.com</URL>
</Websites>

<Websites>
<title>CNN</title>
<country>US</country>
<URL>http://www.cnn.com</URL>
</Websites>

</logs>


***HTML*******


<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<script language="JavaScript" type="text/javascript">

function linksXML()
{
if (document.implementation && document.implementation.createDocument)
{
xmlDoc = document.implementation.createDocument("", "", null);
xmlDoc.onload = createTable;
}
else if (window.ActiveXObject)
{
xmlDoc = new ActiveXObject("Microsoft.XMLDOM");
xmlDoc.onreadystatechange = function () {if (xmlDoc.readyState == 4)
createTable()};
}
else
{
alert('Your browser can\'t handle this script');
return;
}
xmlDoc.load("google.xml");
}





function createTable()

{

var x = xmlDoc.getElementsByTagName('Websites');
var newEl = document.createElement('TABLE');
newEl.setAttribute('cellPadding',5);
var tmp = document.createElement('TBODY');
newEl.appendChild(tmp);
var row = document.createElement('TR');
for (j=0;j<x[0].childNodes.length;j++)
{
if (x[0].childNodes[j].nodeType != 1) continue;
var container = document.createElement('TH');
var theData = document.createTextNode(x[0].childNodes[j].nodeName);
container.appendChild(theData);
row.appendChild(container);
}
tmp.appendChild(row);
for (i=0;i<x.length;i++)
{
var row = document.createElement('TR');
for (j=0;j<x.childNodes.length;j++)
{
if (x.childNodes[j].nodeType != 1) continue;
var container = document.createElement('TD');
var theData =
document.createTextNode(x.childNodes[j].firstChild.nodeValue);
container.appendChild(theData);
row.appendChild(container);
}
tmp.appendChild(row);
}
document.getElementById('writeroot1').appendChild(newEl);

}


</script>
</head>
<body>

<a href="javascript:linksXML()">Test</a>

<p id="writeroot1" style="background-color: green;">
</p>

</body>
</html>
 
M

Martin Honnen

I am developing a page for Mozilla/IE which reads xml data and when the
link on the page is clicked it displays the data as a table.
The display is controlled by a Javascript. Everything works fine. But
in the table one of the sections is a URL. I want this to be clickable
so that it takes me to the corresponding webpage.
Click to expand...

"clickable"? So you want a link in the HTML document?
var link = document.createElement('a');
link.href = 'http://example.com/';
link.appendChild(document.createTextNode('http://example.com/'));
// now append the link element to some other element e.g.
document.body.appendChild(link);
 
A

arun32581

I guess I wasnt being clear. My Xml file has a URL tag. For example say
http://www.google.com. And in the html page when the page loads up
there is a linked text called 'Test'. So when the link 'Test' is
clicked the JavaScript takes the XML table and displays in the html
page. And the URL is simply displayed as a text and not as a link. Its
this link that i want it to be clicked . So when i click the 'Test'
link on the page and when it displays the table on the page, the tag
URL from the XML page needs to be clickable..

Thanks a lot Martin. I appreciate your help
 
R

RobG

I guess I wasnt being clear. My Xml file has a URL tag. For example say
http://www.google.com. And in the html page when the page loads up
there is a linked text called 'Test'. So when the link 'Test' is
clicked the JavaScript takes the XML table and displays in the html
page. And the URL is simply displayed as a text and not as a link. Its
this link that i want it to be clicked . So when i click the 'Test'
link on the page and when it displays the table on the page, the tag
URL from the XML page needs to be clickable..
Click to expand...

Don't top-post, it discourages replies - reply below quoted text.

As you loop through the elements of your XML file, test to see if you
are handling a URL element. If so, add it as an A element using the
method demonstrated by Martin. Otherwise, add text element.

You may want to create separate functions to do that, say toss a
'createA' function a URL and label and get back a ready to go element.

Something like the following should work:

...
tmp.appendChild(row);
// Keep i local
for (var i=0; i<x.length; i++)
{
var row = document.createElement('TR');
// Keep j local
for (var j=0; j<x.childNodes.length; j++) {
var theNode = x.childNodes[j];

if (theNode.nodeType == 1) {
if ('URL' == theNode.nodeName) {
var theData = document.createElement('a');
theData.href = theNode.firstChild.nodeValue;
theData.appendChild(
document.createTextNode(theNode.firstChild.nodeValue));
} else {
var theData =
document.createTextNode(theNode.firstChild.nodeValue);
}
var container = document.createElement('td');
container.appendChild(theData);
row.appendChild(container);
}
}
tmp.appendChild(row);
}
document.getElementById('writeroot1').appendChild(newEl);
...

A few tips:
- declare variables at the start, don't initialise them on every loop
- use variables to hold values rather than make repeated calls to the
document
- make sure counters (i, j, etc.) are *always* local variables,
otherwise you may get very strange results.
- don't use 'continue' (it's removed from the snippet above) - it makes
the logic less clear and hence less maintainable. Use a normal if
block.

If you are using this purely for your own web page, consider JSON
instead of XML. It puts a lot more power in the hands of whoever writes
the data file so you just mess with the data file rather than the file
and the parser.

<URL:http://www.crockford.com/JSON/index.html>

Stay away from XSL/XSLT on the client.

[...]
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Similar Threads

Problem displaying table from xml in explorer 0
Problems with Xml, Javascript 2
In javascript, XML File Create, File Save 2
Only one table shows up with the information 2
Help with code 0
Help with my responsive home page 2
Creating Table with Javascript abd Adding Events dynamically to each 0
How to have two html audio players on one page? 0

Members online

Total: 26 (members: 2, guests: 24)
Robots: 423

Forum statistics

Threads
473,770
Messages
2,569,584
Members
45,075
Latest member
MakersCBDBloodSupport

Latest Threads

Top