roll over

H

HVTN Recruitment

i am trying to add a very simple roll over for my website. when the pages
load most of the images load but there are a couple that don't. if i roll my
mouse over the images that don't come up, they will appear. does anyone have
any suggestions? i checked my image size and it's ok.

thanks!

~kim
 
L

Lee

HVTN Recruitment said:
i am trying to add a very simple roll over for my website. when the pages
load most of the images load but there are a couple that don't. if i roll my
mouse over the images that don't come up, they will appear. does anyone have
any suggestions? i checked my image size and it's ok.
Click to expand...

You've mistyped the names in the src attribute of the image tags.
Maybe because your SHIFT key isn't working.
 
D

Douglas Crockford

i am trying to add a very simple roll over for my website. when the pages
You've mistyped the names in the src attribute of the image tags.
Maybe because your SHIFT key isn't working.
Click to expand...

Too legit to shift.
 
K

Kim Louis

Hi Douglas, thanks for your reply. I'm new at this so could you please
explain your answer?

I checked the spelling and couldn't find anything.

This is the source:

<script language="javascript">
<!--

if (document.images) {

// On images

image1on = new Image();
image1on.src="images/home-on.gif";

image2on = new Image();
image2on.src="images/volunteer-on.gif";

image3on = new Image();
image3on.src="images/faq-on.gif";

image4on = new Image();
image4on.src="images/trials-on.gif";

image5on = new Image();
image5on.src="images/safety-on.gif";

image6on = new Image();
image6on.src="images/community-on.gif";

image7on = new Image();
image7on.src="images/staff-on.gif";

image8on = new Image();
image8on.src="images/links-on.gif";

image9on = new Image();
image9on.src="images/contacts-on.gif";


// Off images

image1off = new Image();
image1off.src="images/home-off.gif";

image2off = new Image();
image2off.src="images/volunteer-off.gif";

image3off = new Image();
image3off.src="images/faq-off.gif";

image4off = new Image();
image4off.src="images/trials-off.gif";

image5off = new Image();
image5off.src="images/safety-off.gif";

image6off = new Image();
image6off.src="images/community-off.gif";

image7off = new Image();
image7off.src="images/staff-off.gif";

image8off = new Image();
image8off.src="images/links-off.gif";

image9off = new Image();
image9off.src="images/contacts-off.gif";
}

function imgOn (imgName) {
if (document.images) {
document [imgName].src = eval(imgName + "on.src");
}
}
function imgOff(imgName) {
if (document.images) {
document[imgName].src = eval(imgName + "off.src");
}
}
// -->

</script>
 
L

Lee

Kim Louis said:
Hi Douglas, thanks for your reply. I'm new at this so could you please
explain your answer?

I checked the spelling and couldn't find anything.

This is the source:
Click to expand...

The error is probably in your HTML, not the JavaScript.
 
E

Evertjan.

Kim Louis wrote on 24 sep 2003 in comp.lang.javascript:
document[imgName].src = eval(imgName + "off.src");
Click to expand...

Why the eval ?

document[imgName].src = imgName + "off.src";

===

Special taskforce against the senseless proliferation of the evil eval.
 
D

Douglas Crockford

I'm new at this
function imgOn (imgName) {
if (document.images) {
document [imgName].src = eval(imgName + "on.src");
}
}
Click to expand...

Who taught you to do this? Who told you to misuse the eval() function that way?
I want to know.

People who are new at this should never use eval(). Never. But you should get in
the habit of making your code more readable. It is hard to make it right if it
is hard to look at.

function imgOn(imgName) {
if (document.images) {
document[imgName].src = imgName + "on.src";
}
}

http://www.crockford.com/javascript/survey.html
 
K

Kim Louis

hmm? i'm not sure why the eval is in there but if i take it out, none of
my images load...

any more suggestions?
 
K

Kim Louis

Thanks! I checked and checked my html but still can't find anything.
Would it be bad to post it to see if you can find something wrong?
Please forgive me if this is not appropriate.

<body bgcolor="#ffffff" text="#000000" link="#cc0000" alink="#66cc00"
vlink="#cc3333">
<table summary="This table contains links to the HVTN" cellpadding="1"
cellspacing="4" border="0" width="406">
<tr valign="center">
<td width="130" align="left">
<a accesskey="b" href="http://www.hvtn.org/">

<img src="images/hvtn.jpg" border="0" alt="HIV Vaccine Trials Network"
LONGDESC="http://www.hvtn.org/" width="130" height="82"></a>
</td>

<td width="360"><center>
<img src="images/hvtu.gif" border="0" alt="HIV Vaccine Trials Unit
Seattle, Washington"
LONGDESC="Welcome to the Fred Hutch HIV Vaccine Trials Unit"
width="360" height="127"></center>
</td>
<td width="150" align="right"><a accesskey="c"
href="http://www.fhcrc.org/">
<img src="images/fhcrc.gif" width="118" height="65"
border="0" alt="Fred Hutchinson Cancer Research Center"
LONGDESC="http://www.fhcrc.org/"></a>

<a href="http://www.washington.edu">
<img src="images/uw.gif" width="150" height="36"
border="0" alt="University of Washington"
LONGDESC="http://www.washington.edu/"></a></td>
</tr></table>

<hr width=100% size="4" color="#000000">

<table summary="This table contains links to other pages with in this
site"
cellpadding="1" cellspacing="0" border="0" width="630" >
<tr valign="top" align="left">
<td width="115" background="images/bg.gif" width="115" height="189">



&nbsp;

<a accesskey="d" href="volunteering.htm"
onMouseOver = "imgOn('image2')"
onMouseOut = "imgOff('image2')">
<img name="image2" src="images/volunteer-off.gif" border="0"
alt="Volunteering" LONGDESC="Link to how to volunteer for a HIV vaccine
trial"
width="115" height="21"></a>


<a accesskey="i" href="faq.htm"
onMouseOver = "imgOn('image3')"
onMouseOut = "imgOff('image3')">
<img name="image3" src="images/faq.gif-off" border="0"
alt="FAQs" LONGDESC="Link to list of frequently asked questions about
HIV vaccine trials"
width="115" height="21"></a>



<a accesskey="y" href="trials.htm"
onMouseOver = "imgOn('image4')"
onMouseOut = "imgOff('image4')">
<img name="image4" src="images/trials-off.gif" border="0" width="115"
height="21"
alt="Trials" LONGDESC="Link to information about our trials"></a>


<a accesskey="k" href="safety.htm"
onMouseOver = "imgOn('image5')"
onMouseOut = "imgOff('image5')">
<img name="image5" src="images/safety-off.gif" border="0" width="115"
height="21"
alt="Safety and Ethics page" LONGDESC="Link to information about safety
and ethics"></a>


<a accesskey="l" href="community.htm"
onMouseOver = "imgOn('image6')"
onMouseOut = "imgOff('image6')">
<img name="image6" src="images/community-off.gif" border="0"
alt="Community Education" LONGDESC="link to a description about our
Community Education"
width="115" height="21"></a>




<a accesskey="n" href="staff.htm"
onMouseOver = "imgOn('image7')"
onMouseOut = "imgOff('image7')">
<img name="image7" src="images/staff-off.gif" border="0" width="115"
height="21"
alt="Staff" LONGDESC="Link to a list of our staff"></a>


<a accesskey="o" href="Links.htm"
onMouseOver = "imgOn('image8')"
onMouseOut = "imgOff('image8')">
<img name="image8" src="images/links-off.gif" border="0" width="115"
height="21"
alt="Web Resources" LONGDESC="Link to other sites regarding HIV and
vaccines"></a>

<a accesskey="p" href="contacts.htm"
onMouseOver = "imgOn('image9')"
onMouseOut = "imgOff('image9')">
<img name="image9" src="images/contacts.gif" border="0" width="115"
height="21"
alt="Contact Information" LONGDESC="Link to how to contact the
HVTU"></a>


<p>

<br>

<br>

</td>
 
E

Evertjan.

Kim Louis wrote on 24 sep 2003 in comp.lang.javascript:
hmm? i'm not sure why the eval is in there but if i take it out, none of
my images load...

any more suggestions?
Click to expand...

should not.

show us the code.
 
L

Lasse Reichstein Nielsen

Douglas Crockford said:
People who are new at this should never use eval(). Never. But you
should get in the habit of making your code more readable. It is
hard to make it right if it is hard to look at.
Click to expand...

Except that this doesn't work.
function imgOn(imgName) {
if (document.images) {
document[imgName].src = imgName + "on.src";
Click to expand...

Should be:
document[imgName].src = window[imgName + "on"].src;
}
}
Click to expand...

/L
 
L

Lee

Kim Louis said:
Thanks! I checked and checked my html but still can't find anything.
Would it be bad to post it to see if you can find something wrong?
Please forgive me if this is not appropriate
Click to expand...

Here's one example of a mistyped src:


<img name="image3" src="images/faq.gif-off" border="0"
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Similar Threads

logger doesn't roll over 3
Pyautogui, cv2 and cannot find image 0
Fading effect between play and play-over and pause and pause-over 0
changing image size on roll over 4
Each roll-over in File? 2
To control mouse roll-over labels in the Netcharts 1
HTML Aligning social media icons 2
How Do I Set text on an Image and use the image as a border? 7

Members online

Total: 24 (members: 1, guests: 23)
Robots: 453

Forum statistics

Threads
473,769
Messages
2,569,579
Members
45,053
Latest member
BrodieSola

Latest Threads

Top