Saving as Text File

[sushant_taneja]

Hello All,

I am coding a text editor and want to save a file with the
extension .txt??

How can I acheive it???

My text editor uses the follwoing code for saving the contents of the
document area in the file:

public void saveFile()
{
if(this.isSaved())
{
try
{

String text = docArea.getText();
FileWriter out = new FileWriter(oFile);
BufferedWriter bufferout = new BufferedWriter(out);
bufferout.write(text, 0, text.length());
bufferout.close();
out.close();
}
catch(IOException ioe)
{
System.out.println(ioe.toString());
}
saved = true;
}
else
{
saved = true;
saveFileAs();
}
}

Please help me out.

Regards,
Sushant Taneja

 

[John B. Matthews]

I am coding a text editor and want to save a file with the
extension .txt??

How can I acheive it???

My text editor uses the follwoing code for saving the contents of the
document area in the file:

public void saveFile()
{
if(this.isSaved())
{
try
{
String text = docArea.getText();
FileWriter out = new FileWriter(oFile);
BufferedWriter bufferout = new BufferedWriter(out);
bufferout.write(text, 0, text.length());

You might try bufferout.flush() at this point in your program.

 

[Arne Vajhøj]

I am coding a text editor and want to save a file with the
extension .txt??

How can I acheive it???

My text editor uses the follwoing code for saving the contents of the
document area in the file:

public void saveFile()
{
if(this.isSaved())
{
try
{

String text = docArea.getText();
FileWriter out = new FileWriter(oFile);
BufferedWriter bufferout = new BufferedWriter(out);
bufferout.write(text, 0, text.length());
bufferout.close();
out.close();
}
catch(IOException ioe)
{
System.out.println(ioe.toString());
}
saved = true;
}
else
{
saved = true;
saveFileAs();
}
}

What happen when you run that code ?

Arne

 

[Arne Vajhøj]

You might try bufferout.flush() at this point in your program.

Calling flush just before close should not make a difference.

Arne

 

[John B. Matthews]

My text editor uses the follwoing code for saving the contents of the
document area in the file:
if(this.isSaved()) { [...]
String text = docArea.getText();
FileWriter out = new FileWriter(oFile);
BufferedWriter bufferout = new BufferedWriter(out);
bufferout.write(text, 0, text.length());

You might try bufferout.flush() at this point in your program.

bufferout.close();
out.close();

Calling flush just before close should not make a difference.

Arne: Good point; it shouldn't matter, and even an empty Dtring will
produce an empty file.

OP: Another thing to check is the value of this.isSaved().

 

[Mike Schilling]

Hello All,

I am coding a text editor and want to save a file with the
extension .txt??

How can I acheive it???

My text editor uses the follwoing code for saving the contents of
the
document area in the file:

public void saveFile()
{
if(this.isSaved())
{
try
{

String text = docArea.getText();
FileWriter out = new FileWriter(oFile);
BufferedWriter bufferout = new BufferedWriter(out);
bufferout.write(text, 0, text.length());
bufferout.close();
out.close();
}
catch(IOException ioe)
{
System.out.println(ioe.toString());
}
saved = true;
}
else
{
saved = true;
saveFileAs();
}
}

Please help me out.

I'd probably break up the text String into lines and use a PrintWriter
to be sure the line terminators get written correctly.

 

[John W Kennedy]

I'd probably break up the text String into lines and use a PrintWriter
to be sure the line terminators get written correctly.

Or use BufferedWriter with BufferedWriter.newLine();

Another problem: the second close (on the underlying FileWriter) is
redundant. BufferedWriter.close() closes the underlying Writer. In fact,
the underlying writer should not be declared at all -- it should just be
"new BufferedWriter(new FileWriter(...))".

And the short-life variables should be declared final, on general
principles.

 

[Arne Vajhøj]

And the short-life variables should be declared final, on general
principles.

Not everyone like to sprinkle final keywords all over the code ...

Arne

 

[Daniel Pitts]

Not everyone like to sprinkle final keywords all over the code ...

Arne

Not everyone like to find an accidentally modified local variable either.

"final" lets me assure myself that I actually have initialized it
exactly once, regardless of the flow of my program.

I despise the idiom
public Result doMyFoo() {
Foo foo = null;
if (hasFoo1()) {
foo = getFoo1();
}
if (hasFoo2()) {
foo = getFoo2();
}
return foo.doFoo(); // Possible NPE, oops!
}
vs:
public Result doMyFoo() {
final Foo foo;
if (hasFoo1()) {
foo = getFoo1();
} else if (hasFoo2()) {
foo = getFoo2();
} else {
return noFooResult();
}
return foo.doFoo();
}

 

[Arne Vajhøj]

Not everyone like to find an accidentally modified local variable either.

I know why it is done.

But to me it is a great solution to a non existing problem.

"final" lets me assure myself that I actually have initialized it
exactly once, regardless of the flow of my program.

I despise the idiom
public Result doMyFoo() {
Foo foo = null;
if (hasFoo1()) {
foo = getFoo1();
}
if (hasFoo2()) {
foo = getFoo2();
}
return foo.doFoo(); // Possible NPE, oops!
}
vs:
public Result doMyFoo() {
final Foo foo;
if (hasFoo1()) {
foo = getFoo1();
} else if (hasFoo2()) {
foo = getFoo2();
} else {
return noFooResult();
}
return foo.doFoo();
}

I really don't like any of those two.

And the first is missing some basic logic. I am
skeptical about whether programmers will be able to apply
final if they are not able to consider the possibility
that both hasFoo1 and hasFoo2 returns false.

Arne

 

[Daniel Pitts]

I know why it is done.

But to me it is a great solution to a non existing problem.


I really don't like any of those two.

And the first is missing some basic logic. I am
skeptical about whether programmers will be able to apply
final if they are not able to consider the possibility
that both hasFoo1 and hasFoo2 returns false.

This is a simplified example. In any case, the possibility the
programmer being a human being and forgetting a line is high over time.
Keep in mind that forgetting is different than not considering.

 

[Roedy Green]

I am coding a text editor and want to save a file with the
extension .txt??

see http://mindprod.com/applet/fileio.html

http://mindprod.com/products1.html#HUNKIO
--
Roedy Green Canadian Mind Products
http://mindprod.com
PM Steven Harper is fixated on the costs of implementing Kyoto, estimated as high as 1% of GDP.
However, he refuses to consider the costs of not implementing Kyoto which the
famous economist Nicholas Stern estimated at 5 to 20% of GDP