Search and replace problem

[Devop]

HI. every one.

I wanted to search a string from a file, then replace it, and write to
the file again.

But i have come up with this solution, where the replaced contents will
be written in to the an other file.

But it does not work.

This error is coming :
Use of uninitialized value in substitution (s///)

Is there any other way to solve this problem. Thanks.


#!/usr/bin/perl -w
#use strict;
use warnings;

my $infile = 'first.xml';
my $outfile = 'second.xml';


my $text1 = 'this is it =';
my $text2 = '{and this is a new} OK '';
undef $/;
open IN, $infile or die "couldn't open the file!";
my $intext = <IN>;
close IN;

$intext =s/$text1/$text2/gi;

open OUT, ">$outfile" or die $!;
print OUT $intext;
close OUT;

 

[Beable van Polasm]

This error is coming :
Use of uninitialized value in substitution (s///)

Is there any other way to solve this problem. Thanks.


#!/usr/bin/perl -w
#use strict;

Please don't comment out use strict. It is your friend.

use warnings;
Good!

my $infile = 'first.xml';
my $outfile = 'second.xml';


my $text1 = 'this is it =';
my $text2 = '{and this is a new} OK '';

^^
This is wrong, surely.

undef $/;
open IN, $infile or die "couldn't open the file!";

This should be;
open IN, $infile or die "couldn't open the file: $!";
^^
Tells you what the error was

my $intext = <IN>;
close IN;

$intext =s/$text1/$text2/gi;

Should be:
$intext =~ s/$text1/$text2/gi;
^^
Note typo.

open OUT, ">$outfile" or die $!;
print OUT $intext;
close OUT;

Also, you might like to use one of the XML modules like XML::Simple
to deal with XML files, rather than using regular expressions.

--

 

[fifo]

HI. every one.

I wanted to search a string from a file, then replace it, and write to
the file again.

But i have come up with this solution, where the replaced contents will
be written in to the an other file.

But it does not work.

This error is coming :
Use of uninitialized value in substitution (s///)

Is there any other way to solve this problem. Thanks.


#!/usr/bin/perl -w
#use strict;

Why have you commented this out?

use warnings;

my $infile = 'first.xml';
my $outfile = 'second.xml';


my $text1 = 'this is it =';
my $text2 = '{and this is a new} OK '';

This shouldn't have compiled ----------^

undef $/;
open IN, $infile or die "couldn't open the file!";

Print out $! as well as your message:

open IN, $infile or die "couldn't open the file: $!";

my $intext = <IN>;
close IN;

$intext =s/$text1/$text2/gi;

Here's your error, this should be:

$intext =~ s/$text1/$text2/gi;

 

[Devop]

Thanks a lot. you showed me my mistake

Please don't comment out use strict. It is your friend.

^^
This is wrong, surely.


This should be;
open IN, $infile or die "couldn't open the file: $!";
^^
Tells you what the error was


Should be:
$intext =~ s/$text1/$text2/gi;
^^
Note typo.


Also, you might like to use one of the XML modules like XML::Simple
to deal with XML files, rather than using regular expressions.