std::cin woes ---- C style macros to the rescue

[Generic Usenet Account]

Sick and tired of the problems that cin was giving me in a menu-driven
CLI application, that accepts numerical inputs (I was getting into an
infinite loop when a non-numerical input was entered), I have gone
ahead and defined the following macro:


#define readStdin(x) while(true) \
{ \
cin >> x; \
if(!cin) \
{ \
cin.clear(); \
cin.ignore(MAX_LINE_LEN, '\n'); \
} \
else \
break; \
}

This macro has been working like a charm for me. Any other
suggestions are welcome. (Yes I know that I can read the line into a
buffer and read input from that buffer, but that's not what I want to
do).

Regards,
KP Bhat

 

[E. Robert Tisdale]

Sick and tired of the problems that cin was giving me in a menu-driven
CLI application, that accepts numerical inputs (I was getting into an
infinite loop when a non-numerical input was entered), I have gone
ahead and defined the following macro:


#define readStdin(x) while(true) \
{ \
cin >> x; \
if(!cin) \
{ \
cin.clear(); \
cin.ignore(MAX_LINE_LEN, '\n'); \
} \
else \
break; \
}

This macro has been working like a charm for me. Any other
suggestions are welcome. (Yes I know that I can read the line into a
buffer and read input from that buffer, but that's not what I want to
do).

So what is your question?

Take a deep breath and tell us what's wrong.
Post a [short] complete program that demonstrates the problem
then show us the error messages that you got from your compiler
and any diagnostic messages that you got when you tried to run it.

 

[Simon Saunders]

Sick and tired of the problems that cin was giving me in a menu-driven
CLI application, that accepts numerical inputs (I was getting into an
infinite loop when a non-numerical input was entered), I have gone
ahead and defined the following macro:


#define readStdin(x) while(true) \
{ \
cin >> x; \
if(!cin) \
{ \
cin.clear(); \
cin.ignore(MAX_LINE_LEN, '\n'); \
} \
else \
break; \
}

This macro has been working like a charm for me. Any other
suggestions are welcome. (Yes I know that I can read the line into a
buffer and read input from that buffer, but that's not what I want to
do).

I prefer to avoid macros where possible. I'd write it as a function
template:

template <typename T>
void readStdin(T& x)
{
....
}

Perhaps there ought to be a return value indicating success/failure.

 

[Rob Williscroft]

E. Robert Tisdale wrote in

So what is your question?

It's right there above your question: "...Any other suggestions are
welcome. ... "

HTH.

Rob.