syntax question

[Rosco]

What is wrong with the syntax in the following bit of code:

sub convert($dec){
$hex = $dec;
if($dec==10){$hex = "A"}
else{if($dec==11){$hex = "B"}}
else{if($dec==12){$hex = "C"}}
else{if($dec==13){$hex = "D"}}
else{if($dec==14){$hex = "E"}}
else{if($dec==15){$hex = "F"}}
return $hex
};

 

[GoMonitor/LanOnLine Incorporation]

Why don't you do this:

sub convert($dec){
@hex = ('0','1','2','3','4','5','6','7','8','9','A','B','C','D','E','F');
return @Alpha[$dec];

and save some headache
Regards

else{if($dec==11){$hex = "B"}}
else{if($dec==12){$hex = "C"}}
else{if($dec==13){$hex = "D"}}
else{if($dec==14){$hex = "E"}}
else{if($dec==15){$hex = "F"}}
return $hex
};

 

[PapaBear]

And a recode of your snippet would be:

<CODE>
sub convert {
$dec = $_;
$hex = $dec;
if($dec==10){$hex = "A"}
elsif($dec==11){$hex = "B"}
elsif($dec==12){$hex = "C"}
elsif($dec==13){$hex = "D"}
elsif($dec==14){$hex = "E"}
elsif($dec==15){$hex = "F"}
return $hex;
}
</CODE>

 

[PapaBear]

Or, why not do it the whole number in one time, instead of digit by digit?
(works for digits as well, of course)

sub d2h {
return sprintf "%lx", $_;
}