download zip

[thanh toan]

I can download the zip file, but can't extract it with jar. The zip size is
correct. Thank you.

import java.net.*;

import java.io.*;

public class downloadZip

{

public static void main(String args[]) throws Exception

{


URL yh = new URL("the url of the zip file");

InputStreamReader in = new InputStreamReader( yh.openStream());

FileWriter out = new FileWriter("the name of the zip file");

int m;

while( (m= in.read()) != -1 )

{

out.write(m);

}



in.close();

out.close();




}

}

 

[Andrew Thompson]

I can download the zip file, but can't extract it with jar.

Why not? What is the error or result?

...The zip size is correct. Thank you.

Don't forget to 'flush' your streams, your current code does not.

 

[Thomas Weidenfeller]

I can download the zip file, but can't extract it with jar. The zip size is
correct. Thank you. [...]

InputStreamReader in = new InputStreamReader( yh.openStream());

FileWriter out = new FileWriter("the name of the zip file");

You are using character Readers/Writers on a binary file.

/Thomas

 

[thanh toan]

The error message is ugly. Thank you both for telling flush() and read
binary. I used the following and it works.
and for the line

byte buffer[] = new buffer[255] make the downloaded zip corrupted, but if I
used this
byte buffer[] = new buffer[1], the downloaded zip extracts very ok.




import java.net.*;

import java.io.*;

public class downloadZip

{

public static void main(String args[]) throws Exception

{


URL yahoo = new URL("the url of the zip file");

DataInputStream in = new DataInputStream(yahoo.openStream() );

FileOutputStream out = new FileOutputStream("the name of the zip
file");

byte buffer[] = new byte[1]; /*if i tried 255, downloaded zip is
corrupted, but 1 works */




while( in.read(buffer) != -1)

{

out.write(buffer,0,buffer.length);

}

out.flush();

in.close();

out.close();






}

}

codes/ Web & IT Help

 

[Andrew Thompson]

The error message is ugly.

LOL yes, they often are, but necessary and helpful.
<http://www.physci.org/codes/javafaq.jsp#stacktrace>
...because they give detailed information that can help solve the problem..

..Thank you both for telling flush() and read
binary. I used the following and it works.

Cool. Glad you got it working.