Problem with codewars.

[justateanapple]

hello

im trying to learn c++ so i thaught id do the easy stuff on codewars, please can someone help me find out whats wrong with my code. the the quadrant one. i didnt know i knew so little lol its different actually coding and not just following tutorials, ive serched for answers to the errors, these are the ones i couldnt find answers too.

My code:

int quadrent;
int function(int x, int y)
{
if(x > 0 && y > 0)
{
quadrent = 1;
}
else if(x < 0 && y > 0)
{
quadrent = 2;
}
else if(x < 0 && y < 0)
{
quadrent = 3;
}
else if(x > 0 && y < 0)
{
quadrent = 4;
}
}
int main()
{
int function(x, y);
}

the errors:

In file included from main.cpp:6:
./solution.cpp:20:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
./solution.cpp:23:14: error: C++ requires a type specifier for all declarations
int function(x, y);
             ^
./solution.cpp:23:17: error: unknown type name 'y'
int function(x, y);
                ^
In file included from main.cpp:7:
./tests.cpp:3:18: error: use of undeclared identifier 'quadrant'
    Assert::That(quadrant(1, 2), Equals(1));
                 ^
./tests.cpp:4:18: error: use of undeclared identifier 'quadrant'
    Assert::That(quadrant(3, 5), Equals(1));
                 ^
./tests.cpp:5:18: error: use of undeclared identifier 'quadrant'
    Assert::That(quadrant(-10, 100), Equals(2));
                 ^
./tests.cpp:6:18: error: use of undeclared identifier 'quadrant'
    Assert::That(quadrant(-1, -9), Equals(3));
                 ^
./tests.cpp:7:18: error: use of undeclared identifier 'quadrant'
    Assert::That(quadrant(19, -56), Equals(4));
                 ^
main.cpp:9:5: error: conflicting types for 'main'
int main(int, const char *[]) {
    ^
./solution.cpp:21:5: note: previous definition is here
int main()
    ^
1 warning and 8 errors generated.

 

[VBService]

Check this e.g.
[ working code on-line ]

#include <iostream>

using namespace std;

int quadrent;
void function(int x, int y)
{
    if(x > 0 && y > 0)
    {
        quadrent = 1;
    }
    else if(x < 0 && y > 0)
    {
        quadrent = 2;
    }
    else if(x < 0 && y < 0)
    {
        quadrent = 3;
    }
    else if(x > 0 && y < 0)
    {
        quadrent = 4;
    }
}

int main()
{
    int x=1, y=1;
    function(x, y);
    cout << quadrent;
}

 

[justateanapple]

so basically i messed the main up? i had same errors in previous attempts, its always got to do with other functions and main. thank you so much, really helped alot.

all the best.

 

[justateanapple]

okay i just copy pasted into code wars and it was still wrong, someone online said codewars needs return values, and no need for main. but thank you im proud that my code was 99% similar to your example you gave me.

 

[VBService]

needs return values

[ working code on-line ]

int function(int x, int y)
{
    int quadrent;
   
    if(x > 0 && y > 0)
    {
        quadrent = 1;
    }
    else if(x < 0 && y > 0)
    {
        quadrent = 2;
    }
    else if(x < 0 && y < 0)
    {
        quadrent = 3;
    }
    else if(x > 0 && y < 0)
    {
        quadrent = 4;
    }
   
    return quadrent;
}

#include <iostream>

using namespace std;


int function(int x, int y)
{
    int quadrent;
    
    if(x > 0 && y > 0)
    {
        quadrent = 1;
    }
    else if(x < 0 && y > 0)
    {
        quadrent = 2;
    }
    else if(x < 0 && y < 0)
    {
        quadrent = 3;
    }
    else if(x > 0 && y < 0)
    {
        quadrent = 4;
    }
    
    return quadrent;
}

int main()
{
    int x=1, y=1;
    
    cout << function(x, y);
    
    return 0;
}

 

[Yazidi]

First you put an int before the function (the one who after int main)
functions don't have data type
Then you didn't define x and y
So
int x;
int y;
cin>>x>>y;
functionAB(x, y);
cout<<quadrent;

change the function name because the name function it will cause a conflict at naming