destroying recordsets

[middletree]

Assuming I had a recordset set up like this:

Set rs = Server.CreateObject("ADODB.Recordset")

is it enough to close out the code with

set rs=nothing

or is there a benefit to
rs.close
set rs=nothing ?

 

[Aaron Bertrand - MVP]

I *always* use rs.close: set rs = nothing

Is there a benefit to leaving out rs.close?

 

[middletree]

Nope; just asking if it helped to do it, or if it was being redundant.

thanks

 

[Conax]

Nowadays I never use rs.close anymore. I haven't had any problem not using
it.

I guess it's ok if you want to use it in a simple method. But if want to use
it in a more complex method that opens and closes the recordset multiple
times, you will better check to see the state of the recordset first before
calling rs.close, because if the recordset is already closed, you'll get an
error calling rs.close.

Regards
Conax

 

[Tom B]

But since you don't "open" your recordsets, you use the connection.execute
method, you don't need to close them

 

[Bob Barrows]

Nowadays I never use rs.close anymore. I haven't had any problem not
using it.

I guess it's ok if you want to use it in a simple method. But if want
to use it in a more complex method that opens and closes the
recordset multiple times, you will better check to see the state of
the recordset first before calling rs.close, because if the recordset
is already closed, you'll get an error calling rs.close.

Ummm - that's why you use "on error resume next" before running your cleanup
code ...

If you haven't been closing you recordsets, I submit that you've been lucky
not to have run into problems.

Bob Barrows

 

[Bob Barrows]

But since you don't "open" your recordsets, you use the
connection.execute method, you don't need to close them

I do anyways. There is no real good reason not to.

Bob Barrows

 

[Aaron Bertrand [MVP]]

But since you don't "open" your recordsets, you use the connection.execute

method, you don't need to close them

I believe the recordset is still opened, even if you don't do so explicitly.

If it weren't, you would get an error about invalid operation for an object
in this state, or something like that (I forget the exact error message),
when you called rs.close() ...

 

[TomB]

A good point gentlemen. Consider my wrist slapped.


FYI:
http://msdn.microsoft.com/library/d...en-us/ado270/htm/mdaexamples_vbscript01_4.asp

shows an example, and in it they check the recordset state before closing
it.