calling inherited constructors

[Joe, G.I.]

I didn't write ClassA, but I'm trying to inherit from ClassA through
ClassB. I want to pass a string to the ClassA constructor but not sure
I'm calling ClassA's constructor correctly. I get the following g++
error ...

In constructor 'ClassB::ClassB(String&)':
../../../include/ClassB.h:19: error: expected `{' at end of input


ClassB *myClass = new ClassB("myClassName");

// ClassB.h
class ClassB : public ClassA {
ClassB(String &name) : ClassA(name);
}

// ClassB.cpp
ClassB::ClassB(String &name)
{
}

// ClassA constructor which I'm trying to pass the string to ...
ClassA::ClassA (const String & name)



What am I doing wrong here?

 

[Ian Collins]

I didn't write ClassA, but I'm trying to inherit from ClassA through
ClassB. I want to pass a string to the ClassA constructor but not sure
I'm calling ClassA's constructor correctly. I get the following g++
error ...

In constructor 'ClassB::ClassB(String&)':
../../../include/ClassB.h:19: error: expected `{' at end of input


ClassB *myClass = new ClassB("myClassName");

// ClassB.h
class ClassB : public ClassA {
ClassB(String &name) : ClassA(name);
}

class ClassB : public ClassA
{
ClassB(String &name);
};

// ClassB.cpp
ClassB::ClassB(String &name)
{
}

ClassB::ClassB(String &name)
: ClassA( name )
{
}

 

[Andre Kostur]

I didn't write ClassA, but I'm trying to inherit from ClassA through
ClassB. I want to pass a string to the ClassA constructor but not sure
I'm calling ClassA's constructor correctly. I get the following g++
error ...

In constructor 'ClassB::ClassB(String&)':
../../../include/ClassB.h:19: error: expected `{' at end of input


ClassB *myClass = new ClassB("myClassName");

// ClassB.h
class ClassB : public ClassA {
ClassB(String &name) : ClassA(name);
}

// ClassB.cpp
ClassB::ClassB(String &name)
{
}

// ClassA constructor which I'm trying to pass the string to ...
ClassA::ClassA (const String & name)



What am I doing wrong here?

Assuming you fix the minor issues (like the missing semicolon at the end of
the class declaration), the piece you've got wrong is that the initializer
list goes with the constructor definition, not the declaration:

class ClassB : public ClassA {
ClassB(String & name);
};

ClassB::ClassB(String & name) : ClassA(name) {}


Something else to consider... do you really want to pass the String by non-
const reference? Generally speaking, if you're passing stuff by reference,
you should probably pass it by const-reference (unless you have a specific
reason to pass it non-const...)