composition or inheritance for a jdialog

[-]

i current have a subclass of JDialog that has only these two lines in
the constructor:

getRootPane().getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(
KeyStroke.getKeyStroke(KeyEvent.VK_ESCAPE, 0),
DISPOSE_ACTION_KEY);
getRootPane().getActionMap().put(DISPOSE_ACTION_KEY,
new AbstractAction() {
public void actionPerformed(ActionEvent evt) {
dispose();
}
});


is it right to subclass it? or should i switch to composition?

 

[John C. Bollinger]

i current have a subclass of JDialog that has only these two lines in
the constructor:

getRootPane().getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(
KeyStroke.getKeyStroke(KeyEvent.VK_ESCAPE, 0),
DISPOSE_ACTION_KEY);
getRootPane().getActionMap().put(DISPOSE_ACTION_KEY,
new AbstractAction() {
public void actionPerformed(ActionEvent evt) {
dispose();
}
});


is it right to subclass it? or should i switch to composition?

I try to avoid subclassing GUI components. There are sometimes good
reasons to do it, but the example you have presented does not exhibit one.